Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failing in every PR #27150

Closed
wants to merge 1 commit into from

Conversation

AdrianFreundQC
Copy link

@AdrianFreundQC AdrianFreundQC commented Aug 1, 2024

Fix staged-reciped CI failing on every PR by pinning conda_build to <24.7.
.ci_support/compute_build_graph.py import HashableDict from conda_build. This has been removed in 24.7 and has been deprecated since 24.5. They recommend using frozendict instead.
Until the code has been updated to not use HashableDict we can just pin conda_build to an older version.

I don't have permission to add the maintainance tag to this PR, so linter complains about changing non-recipe files.

Closes conda-forge/conda-forge-ci-setup-feedstock#332

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kubeseal/meta.yaml) and found some lint.

Here's what I've got...

For recipes/kubeseal/meta.yaml:

  • The following maintainers have not yet confirmed that they are willing to be listed here: 0xbe7a. Please ask them to comment on this PR if they are.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@AdrianFreundQC AdrianFreundQC changed the title Add kubeseal Try fixing CI Aug 1, 2024
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@AdrianFreundQC
Copy link
Author

Removed the recipe I used to test from this PR again.
Now ready for review.

@conda-forge/staged-recipes

Copy link

github-actions bot commented Aug 1, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@AdrianFreundQC AdrianFreundQC changed the title Try fixing CI Fix CI failing in every PR Aug 1, 2024
@AdrianFreundQC
Copy link
Author

Superseded by #27151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

cannot import name 'HashableDict' from 'conda_build.utils'
2 participants