Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libint2 #22060

Closed
wants to merge 20 commits into from
Closed

add libint2 #22060

wants to merge 20 commits into from

Conversation

loriab
Copy link
Contributor

@loriab loriab commented Feb 17, 2023

  • static libs: Linux and Mac are properly shipping only the dynamic libraries. Windows is only building the static library as there's some declspec's that, I suspect, need adding to the upstream project (data symbols in Windows shared library evaleev/libint#237). I think this is ok wrt CFEP-18.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libint2) and found some lint.

Here's what I've got...

For recipes/libint2:

  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/libint2:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libint2) and found some lint.

Here's what I've got...

For recipes/libint2:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libint2) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libint2) and found some lint.

Here's what I've got...

For recipes/libint2:

  • Jinja2 variable definitions are suggested to take a {%<one space>set<one space><variable name><one space>=<one space><expression><one space>%} form. See lines [21]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libint2) and found it was in an excellent condition.

@awvwgk
Copy link
Member

awvwgk commented Feb 20, 2023

How does this recipe relate to https://github.com/conda-forge/libint-feedstock? Have just seen conda-forge/libint-feedstock#15.

@loriab
Copy link
Contributor Author

loriab commented Mar 20, 2023

closed in favor of dev release on existing libint feedstock conda-forge/libint-feedstock#17

@loriab loriab closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants