Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfdk_acc: Do not support building for Android when using NDK #24583

Merged
merged 2 commits into from
Jul 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions recipes/libfdk_aac/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
from conan.tools.gnu import Autotools, AutotoolsToolchain
from conan.tools.layout import basic_layout
from conan.tools.microsoft import is_msvc, NMakeToolchain
from conan.tools.build import cross_building
from conan.tools.scm import Version
from conan.errors import ConanInvalidConfiguration
import os

required_conan_version = ">=1.55.0"
Expand Down Expand Up @@ -46,6 +48,12 @@ def configure(self):
if self.options.shared:
self.options.rm_safe("fPIC")

def validate_build(self):
if cross_building(self) and self.settings.os == "Android":
# https://github.com/mstorsjo/fdk-aac/issues/124#issuecomment-653473956
# INFO: It's possible to inject a log.h to fix the error, but there is no official support.
raise ConanInvalidConfiguration(f"{self.ref} cross-building for Android is not supported. Please, try native build.")

def layout(self):
if self._use_cmake:
cmake_layout(self, src_folder="src")
Expand Down
Loading