Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libfdk_acc: Do not support building for Android when using NDK #24583

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

uilianries
Copy link
Member

Summary

Changes to recipe: libfdk_acc/2.0.4

Motivation

The issue #20511 points an error when building ffmpeg for Android:

[ 66%] Building CXX object CMakeFiles/fdk-aac.dir/libSBRdec/src/lpp_tran.cpp.o
/Users/paulo/.conan/data/libfdk_aac/2.0.2/_/_/build/36795b10a36cc186da0ea4af22f48240bd009d62/src/libSBRdec/src/lpp_tran.cpp:122:10: fatal error: 'log/log.h' file not found
#include "log/log.h"
         ^~~~~~~~~~~
1 error generated.

That error comes from fdk-aac. It's missing a header named as log.h, the same error is reported in the upstream already:

The author is clear about not supporting NDK here: mstorsjo/fdk-aac#124

Details

It's possible to fix the build error by adding a log file, as suggested here: mstorsjo/fdk-aac#150 (comment)

Does it build? Yes, I tested locally.

Does it work? No idea, plus, the author did not recommend an official way to support, so I preferred to just drop that support.

Related to the PR #24566


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (f79ae7230beafab2279c8b2fd42ba6f771319c53):

  • libfdk_aac/2.0.0:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.3:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.2:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (f79ae7230beafab2279c8b2fd42ba6f771319c53):

  • libfdk_aac/2.0.3:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.2:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.1:
    All packages built successfully! (All logs)

  • libfdk_aac/2.0.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 6966ae1 into conan-io:master Jul 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants