GStreamer: Added new versions and conan v2 support #14907

larshg · 2022-12-23T11:23:16Z

Specify library name and version: 1.14.5, 1.19.2 and 1.20.5

Added several versions
Updated to support conan V2

superseeds and consolidates #13537 and #13400

I've read the contributing guidelines.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2022-12-23T11:23:22Z

All committers have signed the CLA.

Updated to support conan V2

Fix license from >1.20

library: reorganize imports.

larshg · 2022-12-23T12:32:49Z

Version >1.20 fails to build statically with the following error:
[1840/1843] Linking target gstreamer-full-1.0.dll
FAILED: gstreamer-full-1.0.dll
"link" @gstreamer-full-1.0.dll.rsp
Microsoft (R) Incremental Linker Version 14.34.31933.0
Copyright (C) Microsoft Corporation. All rights reserved.

gstreamer-full-1.0.dll.rsp : fatal error LNK1170: line in command file contains 131071 or more characters

Seems like a meson / MSVC Linker issue.

Should static builds be disabled for those versions somehow?

prince-chrismc

This looks super good, just a few questions + minor suggestions

prince-chrismc · 2022-12-28T22:57:04Z

recipes/gstreamer/all/conanfile.py

-    def requirements(self):
-        self.requires("glib/2.72.0")
+    def configure(self):
+        if self.options.shared or self.settings.os == "Windows":


Ooo is there a reason for this over the previous https://github.com/conan-io/conan-center-index/pull/14907/files#diff-d1cfbce329c3bde12538b6a137c150e9f5a5ab88d43c888d5d20bbb4f2f0c8b6L51-L53

del in config options?

I have just "merged" the condtions from configure and config_options - but they are called independently or?

They are called independently. Most notably to the user before or after passing the command line input.

Our usual template give the best UX.

if you set fpic on windows it's a hard error (since that just isnt a thing)

If you pass fpic on linux but also shared it just disgarded since the value need to be true

you need to pass one option instead of worrying about both + this matches the internal logic of the helpers

Not entirely sure how its notably to the user, if its removed in either calls, but I have reverted to having both configure and config_options. I'll try read about the two.

Ahh, I think I get it now. If they are removed in config_options, you get an error if you try set it in your conan call, since its no longer an option.
If removed in configure, you won't get an error even if you tried to set it - hence it can be more difficult to actually figure out if the value you try to set is actually used or not.

recipes/gstreamer/all/conanfile.py

recipes/gstreamer/config.yml

self.info is only for package ID Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

larshg · 2023-01-02T07:12:58Z

When is 1.56 installed on the build servers? Should I try with 1.54?

larshg · 2023-01-03T08:45:50Z

Requires a fix added in 1.56.

prince-chrismc · 2023-01-03T21:33:15Z

When is 1.56 installed on the build servers? Should I try with 1.54?

It will be a while, CCI is general 1 release behind. I'd suggest making it work with 1.54 or we'll have to be patient 😞

prince-chrismc

Just one question about the license change :) otherwise it looks good + I tried to answer some of the previous stuff

prince-chrismc · 2023-01-03T21:33:59Z

recipes/gstreamer/all/conanfile.py

    url = "https://github.com/conan-io/conan-center-index"
    homepage = "https://gstreamer.freedesktop.org/"
-    license = "GPL-2.0-only"
+    license = "LGPL-2.0-or-later"


Why was this changed?

I did due to the other PR did it 😄
But reading this it should be correct to change it to LGPL.

prince-chrismc · 2023-01-03T21:36:38Z

recipes/gstreamer/all/conanfile.py

-    def requirements(self):
-        self.requires("glib/2.72.0")
+    def configure(self):
+        if self.options.shared or self.settings.os == "Windows":


They are called independently. Most notably to the user before or after passing the command line input.

Our usual template give the best UX.

if you set fpic on windows it's a hard error (since that just isnt a thing)

If you pass fpic on linux but also shared it just disgarded since the value need to be true

you need to pass one option instead of worrying about both + this matches the internal logic of the helpers

prince-chrismc · 2023-01-03T21:37:59Z

recipes/gstreamer/all/conanfile.py


    def validate(self):
-        if not self.options["glib"].shared and self.options.shared:
+        if not self.dependencies.direct_host["glib"].options.shared and self.options.shared:


Ooo https://docs.conan.io/en/latest/reference/conanfile/dependencies.html?highlight=direct_host new stuff!

recipes/gstreamer/config.yml

larshg · 2023-01-04T07:21:18Z

I think currently it fails with 1.54, due to this being fixed, which is available from 1.56.
So I don't think we can fix it in the recipe - only by omitting the -pr:b profile, but I guess its not setable for the build on the CI?

prince-chrismc · 2023-01-17T19:16:19Z

c3i was update so lets give it a try

stale · 2023-02-18T00:33:58Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

conan-center-bot · 2023-02-21T14:05:01Z

Conan v1 pipeline ❌

Sorry, the system is under maintenance and it doesn't accept builds right now. Thanks for your understanding and help with the Conan Center Index!

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Sorry, the system is under maintenance and it doesn't accept builds right now. Thanks for your understanding and help with the Conan Center Index!

larshg · 2023-02-21T14:06:44Z

@prince-chrismc Something I can do about the timeout it mentions for gstreamer/1.19.1@macOS, Clang ?

stale · 2023-03-25T07:38:30Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2023-04-25T22:34:27Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

conan-center-bot added the User-approval pending label Dec 23, 2022

This comment has been minimized.

Sign in to view

larshg mentioned this pull request Dec 23, 2022

[!!] Access request #4

Open

Added gstreamer 1.20.4 and 1.20.5.

fac2ae1

Updated to support conan V2

This was referenced Dec 23, 2022

[service] Potentially conflicting recipes #3571

Closed

gstreamer: Add version 1.20 #13537

Merged

larshg added 4 commits December 23, 2022 12:36

Format using autopep8

1f94788

Fixups according to hooks.

791e520

Added v 1.14.5 and 1.19.2

a09780a

Fix license from >1.20

Fix import statement.

8797875

larshg force-pushed the updategstreamer branch from b4ecfa5 to 8797875 Compare December 23, 2022 11:37

This comment has been minimized.

Sign in to view

Test: remove unused import.

200152e

library: reorganize imports.

This comment has been minimized.

Sign in to view

Remove fPIC if on windows.

2567e5e

larshg force-pushed the updategstreamer branch from 80ef0de to 2567e5e Compare December 23, 2022 12:20

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Dec 23, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

ghost mentioned this pull request Dec 23, 2022

gstreamer: Support Conan V2 #13400

Merged

4 tasks

prince-chrismc reviewed Dec 28, 2022

View reviewed changes

conan-center-bot added the Failed label Dec 29, 2022

This comment has been minimized.

Sign in to view

Update recipes/gstreamer/all/conanfile.py

fca7174

self.info is only for package ID Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

conan-center-bot removed the User-approval pending label Jan 2, 2023

This comment has been minimized.

Sign in to view

Remove 1.20.4.

75d83f9

This comment has been minimized.

Sign in to view

larshg force-pushed the updategstreamer branch from 7702a52 to 75d83f9 Compare January 3, 2023 08:44

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Jan 3, 2023

View reviewed changes

Revert to use both configure and config_options.

a4ca9e6

This comment has been minimized.

Sign in to view

prince-chrismc closed this Jan 17, 2023

prince-chrismc reopened this Jan 17, 2023

This comment has been minimized.

Sign in to view

stale bot added the stale label Feb 18, 2023

larshg closed this Feb 21, 2023

larshg reopened this Feb 21, 2023

stale bot removed the stale label Feb 21, 2023

conan-center-bot added Service Under Maintenance and removed Failed labels Feb 21, 2023

stale bot added the stale label Mar 25, 2023

ghost mentioned this pull request Mar 26, 2023

gstreamer: Adding tool_requires/build_requires for Glib #16715

Closed

3 tasks

stale bot closed this Apr 25, 2023

GStreamer: Added new versions and conan v2 support #14907

GStreamer: Added new versions and conan v2 support #14907

Conversation

larshg commented Dec 23, 2022 • edited Loading

CLAassistant commented Dec 23, 2022 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

larshg commented Dec 23, 2022

prince-chrismc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

larshg Jan 4, 2023 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

larshg commented Jan 2, 2023

This comment has been minimized.

This comment has been minimized.

larshg commented Jan 3, 2023

This comment has been minimized.

prince-chrismc commented Jan 3, 2023

prince-chrismc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

larshg commented Jan 4, 2023

prince-chrismc commented Jan 17, 2023

This comment has been minimized.

stale bot commented Feb 18, 2023

conan-center-bot commented Feb 21, 2023

Conan v1 pipeline ❌

Conan v2 pipeline (informative, not required for merge) ❌

larshg commented Feb 21, 2023

stale bot commented Mar 25, 2023

stale bot commented Apr 25, 2023

larshg commented Dec 23, 2022 •

edited

Loading

CLAassistant commented Dec 23, 2022 •

edited

Loading

larshg Jan 4, 2023 •

edited

Loading