Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gstreamer: Support Conan V2 #13400

Merged
merged 34 commits into from
May 22, 2023

Conversation

jwillikers
Copy link
Contributor

Add tests for PkgConfigDeps generator as for glib.

Specify library name and version: gstreamer/*


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Waiting on #13394.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Oct 17, 2022

I detected other pull requests that are modifying gstreamer/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Oct 17, 2022
4 tasks
SSE4
SSE4 previously approved these changes Oct 18, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers closed this Nov 2, 2022
@jwillikers jwillikers reopened this Nov 2, 2022
@stale
Copy link

stale bot commented Dec 3, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 3, 2022
@jwillikers jwillikers closed this Dec 3, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented May 17, 2023

The library seems to have been hanging when trying to load a missing .so 🤯
It's now fixed by letting the test find the library. You can now see the proper errors, finally! Thanks a lot to @jcar87 for finding a way to debug it :)

The missing glib in v2 is something we need to handle internally

@jcar87
Copy link
Contributor

jcar87 commented May 17, 2023

(placeholder comment)

@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 59 (c8d8ee3ca48d3d04a3fe712256086f0f209dfc3e):

  • gstreamer/1.18.3@:
    All packages built successfully! (All logs)

  • gstreamer/1.19.1@:
    All packages built successfully! (All logs)

  • gstreamer/1.19.2@:
    All packages built successfully! (All logs)

  • gstreamer/1.18.4@:
    All packages built successfully! (All logs)

  • gstreamer/1.18.0@:
    All packages built successfully! (All logs)

  • gstreamer/1.16.2@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 60 (c8d8ee3ca48d3d04a3fe712256086f0f209dfc3e):

  • gstreamer/1.19.2@:
    All packages built successfully! (All logs)

  • gstreamer/1.18.4@:
    All packages built successfully! (All logs)

  • gstreamer/1.18.0@:
    All packages built successfully! (All logs)

  • gstreamer/1.18.3@:
    All packages built successfully! (All logs)

  • gstreamer/1.19.1@:
    All packages built successfully! (All logs)

  • gstreamer/1.16.2@:
    All packages built successfully! (All logs)

@AbrilRBS
Copy link
Member

Finally! Thank you so much for your patience @jwillikers. CCI's CI is a better tool thanks to the work by @jcar87 and I that went into understanding the root cause of the timeout, so all this time has not been quite for nothing :)

@conan-center-bot conan-center-bot merged commit 69a9bc5 into conan-io:master May 22, 2023
@jwillikers
Copy link
Contributor Author

Finally! Thank you so much for your patience @jwillikers. CCI's CI is a better tool thanks to the work by @jcar87 and I that went into understanding the root cause of the timeout, so all this time has not been quite for nothing :)

@jcar87 @RubenRBS Thanks! I completely understand how long these things can end up taking. I'm excited to see it finally land! Now to package the plugins... the good, the bad, and the ugly ;)

@jwillikers jwillikers deleted the gstreamer-pkg-config-deps branch May 22, 2023 12:45
mlutken pushed a commit to mlutken/conan-center-index that referenced this pull request May 31, 2023
* gstreamer: Support Conan V2

Add test package for PkgConfigDeps generator.

* Fix licenses installation

* Check for pkgconf conf setting

* Fix Apple shared install name

* Fix Python F-string

* Organize versions in descending order

* Update dependencies and use rm_safe

* Fix license

The GStreamer library is LGPL 2.0 or later.
See gst.h.
The use of certain GPL-linked plugins may make it GPL.

* Don't use fix_apple_shared_install_name

This results in the error "otool-classic: can't map file."

* Bump glib to 2.75.1

* Place MesonToolchain last in generate method

* Add glib as a tool_requires for the glib-mkenums tool

* Bump Meson and glib versions

* Remove package_id method

* Update other glib version

* Remove package_id method?

* Update test v1 package

* Add package type

* Update glib to 2.76.0

* Bump glib to version 2.76.1

* Bump CMake version

* Bump glib

* Change CMake project name of test v1 package

* Fix package name

* gstreamer: add timeout when calling test_package and add GST_DEBUG to runtime

* gstreamer test package: generate virtualrunenv

* gstreamer: undo debugging and fix conan2

* gstreamer: fix removal of pdb files on Windows/msvc

* Update recipes/gstreamer/all/conanfile.py

* Update recipes/gstreamer/all/conanfile.py

* Update recipes/gstreamer/all/conanfile.py

* gstreamer test_package: add GST_DEBUG env var

* gstreamer: use newer runenv info

* transitive_libs might be needed after all

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Co-authored-by: Rubén Rincón <rubenrb@jfrog.com>
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jun 1, 2023
* gstreamer: Support Conan V2

Add test package for PkgConfigDeps generator.

* Fix licenses installation

* Check for pkgconf conf setting

* Fix Apple shared install name

* Fix Python F-string

* Organize versions in descending order

* Update dependencies and use rm_safe

* Fix license

The GStreamer library is LGPL 2.0 or later.
See gst.h.
The use of certain GPL-linked plugins may make it GPL.

* Don't use fix_apple_shared_install_name

This results in the error "otool-classic: can't map file."

* Bump glib to 2.75.1

* Place MesonToolchain last in generate method

* Add glib as a tool_requires for the glib-mkenums tool

* Bump Meson and glib versions

* Remove package_id method

* Update other glib version

* Remove package_id method?

* Update test v1 package

* Add package type

* Update glib to 2.76.0

* Bump glib to version 2.76.1

* Bump CMake version

* Bump glib

* Change CMake project name of test v1 package

* Fix package name

* gstreamer: add timeout when calling test_package and add GST_DEBUG to runtime

* gstreamer test package: generate virtualrunenv

* gstreamer: undo debugging and fix conan2

* gstreamer: fix removal of pdb files on Windows/msvc

* Update recipes/gstreamer/all/conanfile.py

* Update recipes/gstreamer/all/conanfile.py

* Update recipes/gstreamer/all/conanfile.py

* gstreamer test_package: add GST_DEBUG env var

* gstreamer: use newer runenv info

* transitive_libs might be needed after all

---------

Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Co-authored-by: Rubén Rincón <rubenrb@jfrog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.