Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: split up reviewing into new file sections #14491

Merged
merged 14 commits into from
Dec 2, 2022
Merged

Docs: split up reviewing into new file sections #14491

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a5d0239
cleanup patches from #14377
Nov 29, 2022
6603952
subfolder dont exist with new generators
Nov 29, 2022
4ec72a9
styling is not enforced
Nov 29, 2022
a343553
move attribute to new home + fix FAQ spelling
Nov 29, 2022
85c949b
delete out date CMake docs from older generators
Nov 29, 2022
6285a75
move test package docs
Nov 29, 2022
0d773c5
delete empty file :)
Nov 29, 2022
9f83c77
fix links
Nov 29, 2022
75ed203
wording + remove duplicated sections
Nov 29, 2022
75171c3
Merge branch 'conan-io:master' into docs/move-reviewing
prince-chrismc Nov 29, 2022
3db42aa
improve mention of future work
Dec 1, 2022
9bd5c80
Merge branch 'conan-io:master' into docs/move-reviewing
prince-chrismc Dec 1, 2022
2e5443d
[docs] Regenerate tables of contents
github-actions[bot] Dec 1, 2022
04dca24
Merge branch 'conan-io:master' into docs/move-reviewing
prince-chrismc Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
styling is not enforced
  • Loading branch information
Christopher McArthur committed Nov 29, 2022
commit 4ec72a9cebd11c8c9cfffe864659f270a8e0a374
10 changes: 0 additions & 10 deletions docs/adding_packages/reviewing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ The following policies are preferred during the review, but not mandatory:

- [Reviewing policies](#reviewing-policies)
- [Contents](#contents)
- [Trailing white-spaces](#trailing-white-spaces)
- [Quotes](#quotes)
- [Order of methods and attributes](#order-of-methods-and-attributes)
- [License Attribute](#license-attribute)
- [CMake](#cmake)
Expand All @@ -19,14 +17,6 @@ The following policies are preferred during the review, but not mandatory:
- [Minimalistic Source Code](#minimalistic-source-code)
- [CMake targets](#cmake-targets)

## Trailing white-spaces

Avoid trailing white-space characters, if possible

## Quotes

If possible, try to avoid mixing single quotes (`'`) and double quotes (`"`) in python code (`conanfile.py`, `test_package/conanfile.py`). Consistency is preferred.

## Order of methods and attributes

Prefer the following order of documented methods in python code (`conanfile.py`, `test_package/conanfile.py`):
Expand Down