-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: split up reviewing into new file sections #14491
Merged
conan-center-bot
merged 14 commits into
conan-io:master
from
prince-chrismc:docs/move-reviewing
Dec 2, 2022
Merged
Docs: split up reviewing into new file sections #14491
conan-center-bot
merged 14 commits into
conan-io:master
from
prince-chrismc:docs/move-reviewing
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prince-chrismc
changed the title
Docs/move reviewing
Docs: split up reviewing into new file sections
Nov 29, 2022
10 tasks
SSE4
reviewed
Nov 30, 2022
|
||
### Testing CMake variables from FindModules | ||
|
||
@prince-chrism write docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Yes
Co-authored-by: prince-chrismc <prince-chrismc@users.noreply.github.com>
SSE4
approved these changes
Dec 2, 2022
uilianries
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs!
conanfile_attributes.md
conans.tools.CMake
(this will come in a future PR under Docs: Improved Structure for "adding packages" to help contributors find information #13673)test_packages
section with it's own fileThis one you can give all the feedback in the world
This does not have any "policy" stuff so I am willing to make changes 😸