Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: extract python library, write a notifier that uses it #3

Merged
merged 11 commits into from
Feb 1, 2023
Merged

Feat: extract python library, write a notifier that uses it #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2e6696e
WIP
brandonjbjelland Jan 28, 2023
d572b72
WIP
brandonjbjelland Jan 29, 2023
90af95f
WIP
brandonjbjelland Jan 30, 2023
6d023cd
WIP
brandonjbjelland Jan 30, 2023
31722be
WIP
brandonjbjelland Jan 30, 2023
f983a39
release prep
brandonjbjelland Feb 1, 2023
e3af783
WIP
brandonjbjelland Feb 1, 2023
d7cd9e2
WIP
brandonjbjelland Feb 1, 2023
dc7b5ca
WIP
brandonjbjelland Feb 1, 2023
79c2840
bugfix
brandonjbjelland Feb 1, 2023
e6958e0
added more readme detail
brandonjbjelland Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP
  • Loading branch information
@brandonjbjelland
brandonjbjelland committed Feb 1, 2023
commit d7cd9e22d9dc1dc50e3f6a744c24565940266b11
4 changes: 2 additions & 2 deletions notifiers/echo-fastapi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ configurations passed to the `execute()` method.

## User story

As an engineer, I want an example notifier showing usage of the python-notifier
library. It would also be useful if this example notifier could output pubsub
As an engineer, I want an example notifier demonstrating usage of the python-notifier
library. It would also be useful if this example notifier emitted pubsub
message contents I can better understand the attribute conditions needed to
build other notifiers.

Expand Down
2 changes: 1 addition & 1 deletion notifiers/echo-fastapi/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ version = "0.1.0"
[tool.poetry.dependencies]
fastapi = "^0.89.1"
python = "^3.10"
python-clouddeploy-notifier = {git = "https://github.com/computeclub/gcp-cloud-deploy-notifiers.git", subdirectory = "lib/python-notifier", branch = "feat/extract-python-library"}
python-clouddeploy-notifier = {git = "https://github.com/computeclub/gcp-cloud-deploy-notifiers.git", subdirectory = "lib/python-notifier", tag = "v0.1.0"}
# python-clouddeploy-notifier = {path = "../../lib/python-notifier", develop = true}
uvicorn = "^0.20.0"

Expand Down
4 changes: 2 additions & 2 deletions notifiers/echo-fastapi/src/notifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ def action(self, config: Dict[str, Any], **kwargs) -> None:
logging.debug("executing the action")
logging.info("config: %s", config)
logging.info("kw_arg_example: %s", kwargs["kw_arg_example"])
logging.info("message_attributes: %s", kwargs["message_attributes"])
logging.debug("action completed")
logging.info("message_attributes: %s", kwargs["message_attributes"].json())
logging.debug("action completed successfully")
2 changes: 1 addition & 1 deletion notifiers/release-auto-promoter/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ version = "0.1.0"
fastapi = "^0.89.1"
google-cloud-deploy = "^1.6.1"
python = "^3.10"
python-clouddeploy-notifier = {git = "https://github.com/computeclub/gcp-cloud-deploy-notifiers.git", subdirectory = "lib/python-notifier", branch = "feat/extract-python-library"}
python-clouddeploy-notifier = {git = "https://github.com/computeclub/gcp-cloud-deploy-notifiers.git", subdirectory = "lib/python-notifier", tag = "v0.1.0"}
# python-clouddeploy-notifier = {path = "../../lib/python-notifier", develop = true}
uvicorn = "^0.20.0"

Expand Down