Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: extract python library, write a notifier that uses it #3

Merged
merged 11 commits into from
Feb 1, 2023
Merged

Feat: extract python library, write a notifier that uses it #3

merged 11 commits into from
Feb 1, 2023

Conversation

brandonjbjelland
Copy link
Contributor

What is this change?

This PR creates a new notifier (release-auto-promoter) using an internal library that performs the common notifier workflow operations.

Why make this change?

  1. Building a notifier is not so hard but requires a lot of repetition currently - many of those steps are not specific to the notifier itself but boilerplate to operate within the framework. The python library here helps reduce effort for notifier authors.
  2. a release-auto-promoter is a simple and obvious notifier to build. An engineer or release manager should have means of promoting releases under expected conditions. This notifier achieves exactly that.

Links

None

@brandonjbjelland brandonjbjelland force-pushed the feat/extract-python-library branch 10 times, most recently from 6d34631 to 9a2788d Compare January 30, 2023 10:04
@brandonjbjelland brandonjbjelland force-pushed the feat/extract-python-library branch from 9a2788d to d572b72 Compare January 30, 2023 10:07
@brandonjbjelland brandonjbjelland force-pushed the feat/extract-python-library branch from bcd1dd6 to 31722be Compare January 30, 2023 10:42
@brandonjbjelland brandonjbjelland merged commit 91f69c2 into main Feb 1, 2023
@brandonjbjelland brandonjbjelland deleted the feat/extract-python-library branch February 1, 2023 08:26
brandonjbjelland added a commit that referenced this pull request Feb 1, 2023
@brandonjbjelland
Feat: extract python library, write a notifier that uses it (#3)
94e8619 
* Created a new notifier: `release-auto-promoter` advances releases by creating rollouts for the next target in a release pipeline when the previous succeeded.
* Extracted a python library to simplify the process of building a notifier.
* bugfixes and various additions across the terraform modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brandonjbjelland