Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for MS²Rescore report #144

Merged
merged 13 commits into from
Apr 10, 2024
Merged

Fixes for MS²Rescore report #144

merged 13 commits into from
Apr 10, 2024

Conversation

ArthurDeclercq
Copy link
Collaborator

@ArthurDeclercq ArthurDeclercq commented Apr 9, 2024 •
edited
Loading

Bug fixes 🪳

  • Fixed identification overlap plot
  • minor changes to report
  • set logging of numba to WARNING to remove spam in debug logging
  • fixed identifications reporting when using Percolator Issue with QC report for percolator #114
  • fixed _fill_missing_precursor_info function

@ArthurDeclercq ArthurDeclercq changed the base branch from main to timsRescore April 9, 2024 15:01
@ArthurDeclercq ArthurDeclercq marked this pull request as ready for review April 10, 2024 09:33
RalfG
RalfG requested changes Apr 10, 2024
View reviewed changes
ms2rescore/core.py Outdated Show resolved Hide resolved
ms2rescore/core.py Outdated Show resolved Hide resolved
ms2rescore/report/generate.py Outdated Show resolved Hide resolved
ms2rescore/report/generate.py Outdated Show resolved Hide resolved
@ArthurDeclercq @RalfG
Apply suggestions from code review ♻️
1999039 
♻️

Co-authored-by: Ralf Gabriels <ralfg@hotmail.be>
@ArthurDeclercq ArthurDeclercq added this to the v3.1.0 milestone Apr 10, 2024
@ArthurDeclercq ArthurDeclercq merged commit 2c55cc2 into timsRescore Apr 10, 2024
5 checks passed
@ArthurDeclercq ArthurDeclercq deleted the peptide-num-fix branch April 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfG RalfG RalfG requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurDeclercq @RalfG