Skip to content

Add reusable action for MSVC + Win SDK overrides #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comments + incorrect variable.
  • Loading branch information
Steelskin committed May 28, 2025
commit 657235678901d8949af2b7f0dfcb0fe7b697a711
8 changes: 4 additions & 4 deletions .github/actions/setup-build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ inputs:
type: boolean
host-arch:
description: |
The compiler's host architecture, "x86", "amd64" or "arm64". Defaults to the build
architecture. (a.k.a. the current runner's architecture).
The output's host architecture, "x86", "amd64" or "arm64". Defaults to the build architecture
(a.k.a. the current runner's architecture).
This is the target architecture for the Visual Studio Developer Environment.
required: false
type: string
Expand All @@ -42,7 +42,7 @@ runs:
} elseif ($IsMacOS) {
$BuildOS = "macosx"
} else {
Write-Output "::error::Unsupported host OS."
Write-Output "::error::Unsupported build OS."
exit 1
}

Expand All @@ -51,7 +51,7 @@ runs:
"X64" { $BuildArch = "amd64" }
"Arm64" { $BuildArch = "arm64" }
default {
Write-Output "::error::Unsupported host architecture: `"$BuildArch`""
Write-Output "::error::Unsupported build architecture: `"$Arch`""
exit 1
}
}
Expand Down