Add reusable action for MSVC + Win SDK overrides #956
Merged
+455
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
May 20, 2025
|
FYI, I am removing the |
This introduces a new reusable action, `setup-build`, which will eventually replace all of the custom installation steps in the swift-build jobs. Currently it only supports providing explicit versions for MSVC and the Windows SDK. This also adds tests for the `setup-build` action, with a configurable runner, ensuring we can catch issues early as runner images get updated.
Steelskin
force-pushed
the
fabrice/setup-build-action
branch
2 times, most recently
from
62d7b6f to
ebe8259
Compare
* Incorrect value passed to `winsdk` in `gha-setup-vsdevenv` * Incorrect test for skipping setting up the VS Dev Environment * Regression tests added
Steelskin
force-pushed
the
fabrice/setup-build-action
branch
from
ebe8259 to
6c8f7d1
Compare
compnerd
reviewed
May 28, 2025
This matches the rest of the workflow's naming convention.
compnerd
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new reusable action,
setup-build, which will eventually replace all of the custom installation steps in the swift-build jobs. Currently it only supports providing explicit versions for MSVC and the Windows SDK.This also adds tests for the
setup-buildaction, with a configurable runner, ensuring we can catch issues early as runner images get updated.Bug: #821