Skip to content

Add reusable action for MSVC + Win SDK overrides #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

Steelskin
Copy link
Collaborator

@Steelskin Steelskin commented May 20, 2025

This introduces a new reusable action, setup-build, which will eventually replace all of the custom installation steps in the swift-build jobs. Currently it only supports providing explicit versions for MSVC and the Windows SDK.

This also adds tests for the setup-build action, with a configurable runner, ensuring we can catch issues early as runner images get updated.

Bug: #821

@Steelskin Steelskin requested a review from compnerd May 20, 2025 18:32
@Steelskin Steelskin requested a review from compnerd May 21, 2025 00:25
@Steelskin
Copy link
Collaborator Author

FYI, I am removing the ::info:: annotations in favor of a ℹ️ emoji. The correct annotation would be ::notice:: but it adds a log in the main action page, which gets quite spammy.

Steelskin added 4 commits May 27, 2025 10:11
This introduces a new reusable action, `setup-build`, which will
eventually replace all of the custom installation steps in the
swift-build jobs. Currently it only supports providing explicit versions
for MSVC and the Windows SDK.

This also adds tests for the `setup-build` action, with a configurable
runner, ensuring we can catch issues early as runner images get updated.
@Steelskin Steelskin force-pushed the fabrice/setup-build-action branch 2 times, most recently from 62d7b6f to ebe8259 Compare May 28, 2025 16:15
* Incorrect value passed to `winsdk` in `gha-setup-vsdevenv`
* Incorrect test for skipping setting up the VS Dev Environment
* Regression tests added
@Steelskin Steelskin force-pushed the fabrice/setup-build-action branch from ebe8259 to 6c8f7d1 Compare May 28, 2025 16:19
This matches the rest of the workflow's naming convention.
@Steelskin Steelskin requested a review from compnerd May 28, 2025 17:05
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes left, but otherwise, this might be ready.

@Steelskin Steelskin merged commit 85e7154 into main May 28, 2025
3 checks passed
@Steelskin Steelskin deleted the fabrice/setup-build-action branch May 28, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants