Skip to content

Conversation

Copy link

Copilot AI commented Oct 9, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>Pytest import errors due to roslibpy 2.0.0 actiolnlib</issue_title>
<issue_description>Describe the bug
according to changelog v2.0.0 moved the location of the actionlib module. https://pypi.org/project/roslibpy/

.venv\Lib\site-packages\compas_rrc\__init__.py:90: in <module>
    from compas_rrc.client import AbbClient, RosClient
.venv\Lib\site-packages\compas_rrc\client.py:5: in <module>
    from compas_fab.backends import RosClient
.venv\Lib\site-packages\compas_fab\backends\__init__.py:122: in <module>
    from .ros import (
.venv\Lib\site-packages\compas_fab\backends\ros\__init__.py:3: in <module>
    from .client import RosClient
.venv\Lib\site-packages\compas_fab\backends\ros\client.py:9: in <module>
    from roslibpy.actionlib import ActionClient
E   ModuleNotFoundError: No module named 'roslibpy.actionlib'

https://github.com/compas-dev/compas_fab/blob/main/src/compas_fab/backends/ros/client.py

To Reproduce
from compas_rrc import AbbClient

Package                   Version     Editable project location
------------------------- ----------- -----------------------------------------------------------------
compas                    2.14.1
compas-fab                1.1.0
compas-robots             0.6.0
compas-rrc                2.0.0
pytest                    8.4.2
roslibpy                  2.0.0

Expected behavior
It should import roslibpy.ros1.actionlib i guess

Screenshots

Add screenshots to help explain your problem (if applicable).

Desktop (please complete the following information):

  • OS: Windows 10
  • Python version 3.12
  • Python package manager uv
    </issue_description>

<agent_instructions>Please prepare a pull request to correct the upper bound dependency on roslibpy to be less than 2.0, also remove the limits on numpy being upper bounded, which I believe are outdated</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@gonzalocasas Oh wow, good catch! Indeed, `roslibpy 2.0` was released yesterday and it includes breaking changes to the API. `compas_fab` should define its dependency as `>1.1,<2` (and then update to support roslibpy 2 + ROS 2.

Fixes #451


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

yck011522 and others added 22 commits June 7, 2024 10:50
Update CI to run on all Pull Requests
…ypoints

Plan_cartesian_motion uses Waypoints class
… class (#436)

* refactor: Use TOL.is_close for checking if scaling is needed in Robot class

* not
Remove Planner call magic, using multi-inherence instead.
Renamed a bunch of `cached_robot` to `cached_robot_model` in PyBulletClient
@gonzalocasas gonzalocasas changed the base branch from main to LTS-main-1.x October 9, 2025 11:08
@gonzalocasas gonzalocasas deleted the copilot/fix-pytest-import-errors branch October 9, 2025 11:09
Copilot AI requested a review from gonzalocasas October 9, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pytest import errors due to roslibpy 2.0.0 actiolnlib

3 participants