-
Notifications
You must be signed in to change notification settings - Fork 38
Remove Planner call magic, using multi-inherence instead. #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @forward_docstring(MoveItForwardKinematics) | ||
| def forward_kinematics(self, *args, **kwargs): | ||
| return MoveItForwardKinematics(self.client)(*args, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
| def plan_cartesian_motion(self, *args, **kwargs): | ||
| return AnalyticalPlanCartesianMotion(self)(*args, **kwargs) | ||
| def __init__(self, connection_type="gui", verbose=False): | ||
| PyBulletClient.__init__(self, connection_type=connection_type, verbose=verbose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct to explicitly use the super class instead of super?
gonzalocasas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A continuation of #424 after I messed things up.