Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update allowed recent years to include 2020s #5761

Merged
merged 14 commits into from
Jul 20, 2024
Merged

Update allowed recent years to include 2020s #5761

merged 14 commits into from
Jul 20, 2024

Commits on Jun 24, 2024

  1. document regex due to commons-app#47

    @mnalis
    mnalis committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    81d553c View commit details
    Browse the repository at this point in the history

  2. also count 2020s as "recent years"

    @mnalis
    mnalis committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    d078b2d View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. clarify that not all years are ignored

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    99e5d1f View commit details
    Browse the repository at this point in the history

  2. clarify "year" is current year

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    8916362 View commit details
    Browse the repository at this point in the history

  3. original logic fix 

    from commons-app#5761 (review)
    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    eafb363 View commit details
    Browse the repository at this point in the history

  4. better variale name for ".*0s.*" 

    as that regex will match e.g. `1920s` and `80s` too, so the original `is20xxsYear` would be confusing name for it
    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    d92225a View commit details
    Browse the repository at this point in the history

  5. consolidate duplicated code to spammyCategory

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    ee1d4c8 View commit details
    Browse the repository at this point in the history

  6. clarify regexes via variables

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    866cf0a View commit details
    Browse the repository at this point in the history

  7. spammyCategory should always be skipped

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    e3c1923 View commit details
    Browse the repository at this point in the history

  8. return is simple now, so we can get rid of extra val oldDecade

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    c545642 View commit details
    Browse the repository at this point in the history

  9. fix curYearInString

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    1ca742d View commit details
    Browse the repository at this point in the history

  10. some clarification comments

    @mnalis
    mnalis committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    4fe4310 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. refactor: rename containsYear to isSpammyCategory 

    This is done as the name containsYear is ambiguous.
It not just checks for year to identify spammy categories.
    @sivaraam
    sivaraam committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    fe74c77 View commit details
    Browse the repository at this point in the history

  2. refactor: rename containsYear to isSpammyCategory (take 2) 

     A continuation of fe74c77 (refactor: rename containsYear
 to isSpammyCategory, 2024-07-17)
    @sivaraam
    sivaraam committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    61445e3 View commit details
    Browse the repository at this point in the history