Update allowed recent years to include 2020s #5761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivaraam
reviewed
Jun 27, 2024
app/src/main/java/fr/free/nrw/commons/category/CategoriesModel.kt
Outdated
Show resolved
Hide resolved
as that regex will match e.g. `1920s` and `80s` too, so the original `is20xxsYear` would be confusing name for it
This is done as the name containsYear is ambiguous. It not just checks for year to identify spammy categories.
A continuation of fe74c77 (refactor: rename containsYear to isSpammyCategory, 2024-07-17)
|
Looks good to me! I think it can be merged, so we can continue with fixing over-skipped years mentioned in #5749 (comment) in other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
As suggested in #5749 (comment), this updates "non-archaic years" filter to include
2020stoo (in addition to existing2000sand2010s)Also adds a comment to identify source of some of the regexes.
Tests performed (required)
Not in position to build/test currently; would appreciate if someone else could check. The change is rather trivial regex change, though.