Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Some pins disappear after switching apps #5512

Conversation

shashankiitbhu
Copy link
Contributor

Description (required)

Fixes #5482

What changes did you make and why?

Tests performed (required)

Tested 4.2.1-debug-main on Xiaomi 11 Lite NE with API level 33

Screenshots (for UI changes only)

WhatsApp.Video.2024-02-04.at.1.49.28.PM.mp4

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this branch somehow no pins get loaded when I open the Nearby activity.
When I try with the main branch, pins load normally.

@shashankiitbhu
Copy link
Contributor Author

shashankiitbhu commented Feb 14, 2024

@nicolas-raoul

With this branch somehow no pins get loaded when I open the Nearby activity. When I try with the main branch, pins load normally.

I can see pins loaded in this branch (with the latest pull from the main):
WhatsApp Image 2024-02-14 at 4 39 42 PM

Can you please provide more information about this? How to reproduce?

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Mar 27, 2024

Sorry for the delay!
Somehow I have not seen this in a while.
Now (in main branch) it seems that every time I switch apps I get more points lol

@shashankiitbhu Do you think it is still needed?

@shashankiitbhu
Copy link
Contributor Author

@nicolas-raoul I think nearby has changed significantly since the time I made this PR. I don't think it's relevant anymore.

Do you want me to fix that Issue Instead? - More Pins appearing? , it could be due to a similar reason.

@nicolas-raoul
Copy link
Member

The current behavior is good. Let's close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nearby: Some pins disappear after switching apps
2 participants