Nearby: Some pins disappear after switching apps

[nicolas-raoul]

... even though I didn't change location (using FakeGPS).

Observed on main branch at 96b2608, but might have started earlier. git bisect will most probably help.

screen-20240127-223908.mp4

[shashankiitbhu]

I think this issue is related to that configuration change issue that I am currently working on in my other PRs , can you assign this to me @nicolas-raoul

[rohit9625]

Did you find out where is the problem? If not then please find it first :)

[nicolas-raoul]

I think it is fine to get assigned before starting to investigate. :-)

[rohit9625]

Yes, you are right. But what I think is, that we should first reproduce the issue and then have a scenario ahead of how a particular issue will be solved.
: )

[nicolas-raoul]

Yes, being able to reproduce can probably be considered a minimum. Different projects have different rules/habits though. 🙂

[rohit9625]

Well yeah 🙂

[shashankiitbhu]

@nicolas-raoul I examined the issue well and I was able to reproduce it as you can see below

WhatsApp.Video.2024-02-04.at.12.07.03.PM.mp4

on deep examination, I found out that this issue is not of some pins disappearing but rather extra pins loading when the view is created, which is because of a duplicate call for performMapReadyActions() in onViewCreated

It calls performMapReadyActions() but also onResume() (even if it doesn't call onResume(), it will get called anyways because it's a lifecycle event) and onResume also calls the startMap() which calls performMapReadyActions()

Due to this repeated call, an extra number of pins are loaded (which could have been otherwise loaded when recentering the map and searching the area), but when you switch apps only onResume is getting called (as it should be) and onViewCreated so the performMapReadyActions() is not called twice which gives us the impression that some pins have disappeared (which is not really the case 😅 )

[nicolas-raoul]

Working fine now.