Removed hardcoded strings in DeleteHelper #3047
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@PavelAplevich you can click here to see the review status or cancel the code review job.
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #3047 +/- ##
======================================
Coverage 4.41% 4.41%
======================================
Files 259 259
Lines 12309 12309
Branches 1056 1056
======================================
Hits 544 544
Misses 11726 11726
Partials 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @PavelAplevich , welcome to team! Please see my minor review. Everything else seems fine to me:)
| @@ -547,4 +547,12 @@ | |||
| <string name="dialog_box_text_nomination">Почему %1$s должно быть удалено?</string> | |||
| <string name="review_is_uploaded_by">%1$s загружено с помощью: %2$s</string> | |||
| <string name="default_description_language">Язык описаний по умолчанию</string> | |||
| <string name="delete_reason_spam_selfie">Селфи</string> | |||
There was a problem hiding this comment.
Removing hard coded strings and inserting them into strings.xml is perfectly fine. But we don't edit language specific strings.xml files manually. We just edit the default one ( app/src/main/res/values/strings.xml) as you also did. For outher languages we have translator updates. Please revert changes in this file.
This reverts commit 4bc55fc.
|
Thanks @PavelAplevich and congrats for your first contribution! 🎉 |
|
@neslihanturan |
* Removed hardcoded strings in DeleteHelper * Revert "Removed hardcoded strings in DeleteHelper" This reverts commit 4bc55fc.
Fixes #3050
Welcome from Belarus!) I'm beginner in programming for Android. And this is my first open-source project.
I hope I can be helpful in this project.
Fixes hardcoded strings in delete/DeleteHelper.java
A small change in the class for the possibility of localization of strings. Adding these strings with localization in Russian.
Tested on Xiaomi Redmi4x and Nexus One(emulator) with API level 25 and 22.
