Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard coded strngs in delete helper #3050

Closed
neslihanturan opened this issue Jul 2, 2019 · 2 comments · Fixed by #3047
Closed

Remove hard coded strngs in delete helper #3050

neslihanturan opened this issue Jul 2, 2019 · 2 comments · Fixed by #3047

Comments

@neslihanturan
Copy link
Collaborator

Summary:
Delete reasons are hardcoded, they should go into strings.xml file.
@PavelAplevich PavelAplevich mentioned this issue Jul 2, 2019
Merged
@PavelAplevich
Copy link
Contributor

I will work on it

@neslihanturan
Copy link
Collaborator Author

I created this issue to link the pull request you have already sent. So after merging your PR, this will be closed. So I created this issue just to keep our repository structured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed hardcoded strings in DeleteHelper
2 participants
@neslihanturan @PavelAplevich