Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effective UI in nightmode #2574

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Effective UI in nightmode #2574

merged 4 commits into from
Mar 11, 2019

Conversation

silkypriya
Copy link
Contributor

@silkypriya silkypriya commented Mar 10, 2019 •
edited
Loading

Description

Improved UI in night mode.

Fixes #2573 Effective UI in night mode

What changes did you make and why?

  1. Changed colour of bottom row buttons for easy visibility in night mode.
Before change After change
bottom_buttons button
  1. Changed navigation header colour in night mode for consistency in UI.
Before change After change
nevigation navi
  1. Changed background colour of achievement activity to make text visible in night mode.
Before change After change
achievement achi
  1. Changed background colour of tutorial activities in night mode same as all other activities.
Before change After change
tutorial tut1

Tests performed

Tested betaDebug on Realme 2 pro (Android Version 8.1.0) with API level 27.

@silkypriya
Copy link
Contributor Author

#2180 Night mode issue list

Also fixes #2446 Night mode: Achievements

nicolas-raoul
nicolas-raoul approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@silkypriya silkypriya mentioned this pull request Mar 11, 2019
Closed
@silkypriya
Copy link
Contributor Author

Hello @nicolas-raoul

The the last commit does

  1. Revert the first commit which was fixing Place bookmark blue buttons hard to see in night mode #2562. I am sorry for the inconvenience.
  2. Change the bottom row button color to slightly light blue in night mode.

Squashing the commits will cause above mentioned four changes.
Fixing issues #2573 and #2446

Would love your feedback.
Thank you!

@nicolas-raoul
Copy link
Member

Would you mind updating the screenshots above? Thanks :-)

@silkypriya
Copy link
Contributor Author

Updated the screenshots.
Thank you! @nicolas-raoul

@maskaravivek maskaravivek merged commit 0a3d8c0 into commons-app:master Mar 11, 2019
@domdomegg domdomegg mentioned this pull request Mar 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-raoul nicolas-raoul nicolas-raoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silkypriya @nicolas-raoul @maskaravivek