Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place bookmark blue buttons hard to see in night mode #2562

Closed
nicolas-raoul opened this issue Mar 9, 2019 · 3 comments
Closed

Place bookmark blue buttons hard to see in night mode #2562

nicolas-raoul opened this issue Mar 9, 2019 · 3 comments

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Mar 9, 2019

Steps to reproduce:

  1. Go to Setting, enable night mode
  2. Go to Nearby, bookmark a place
  3. Go to Bookmarks, select Places tab, tap the place
  4. The blue buttons (bookmark/camera/gallery/directions/...) are hard to see

A slightly lighter blue would be better I think. Especially the directions and ... somehow.

Screen-shots:
Screenshot_20190213-130007
Same in Nearby map.

@silkypriya
Copy link
Contributor

Hello @nicolas-raoul, I'd like to work on this issue.

@silkypriya
Copy link
Contributor

Made pull request for this issue.
Kindly review.
Thank you!

@silkypriya
Copy link
Contributor

silkypriya commented Mar 11, 2019

@nicolas-raoul , @maskaravivek

I have made commit for following changes

  1. In light mode Assign the colour to last two buttons (directions and overflow) same as first three row
    buttons.
  2. In dark mode all row buttons colour changes to slightly lighter blue to be easily visible.

Kindly review #2570
I would love your feedback!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants