Hotfix for overwrite issue in 2.8.0

[neslihanturan]

Title (required)

Fixes #228 Override happens

Description (required)

Fixes #228 What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Otherwise overrides are possible.

Tests performed (required)

BetaDebug, API level 19 (this was the only emulator that I could reproduce the issue)

Fixedthe problem for me.

[whym]

Perhaps we should also check 'title' is without any extension? Some of the tests fail because results like "SampleFile.jpg.jpg" are returned in UtilsFixExtensionTest (and I believe they should not).

And I also suggest adding a new test like this:

@Test
    fun noInformationShouldResultsInJpg() {
        // when null, fall back to jpg (but this solution might not be complete - see PR #1838)
        assertEquals("SampleFile.jpg", fixExtension("SampleFile", null))
    }

We might have to read the content of the file and guess mimetype/extension. (I believe there is a library for doing that.) That could be a separate issue to be worked on, as it might take time to implement.

[neslihanturan]

Thanks for catching @whym . I never thought title with extension possibility. And I will add the test you offered:)

[codecov-io]

Codecov Report

Merging #1838 into 2.8-release will increase coverage by 0.03%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           2.8-release   #1838      +/-   ##
==============================================
+ Coverage         3.64%   3.67%   +0.03%     
==============================================
  Files              188     188              
  Lines             9544    9547       +3     
  Branches           843     844       +1     
==============================================
+ Hits               348     351       +3     
  Misses            9172    9172              
  Partials            24      24

Impacted Files	Coverage Δ
app/src/main/java/fr/free/nrw/commons/Utils.java	27.39% <100%> (+3.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c3772...15ca64c. Read the comment docs.

[misaochan]

Tests:

Uploading a .jpg file via Share or in-app button both work, and does not overwrite
Uploading a .png file via Share fails
Uploading a .png file via in-app button works, and does not overwrite

Merging this for the hotfix anyway, thanks!

[maskaravivek]

Uploading a .png file via Share fails

@misaochan Can you share logs for this scenario.

Edit: Ignore, I just saw your comment on the issue thread. :)