Clear auth cookie while logging out #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.8-release #1875 +/- ##
==============================================
- Coverage 3.67% 3.66% -0.01%
==============================================
Files 188 188
Lines 9555 9565 +10
Branches 846 846
==============================================
Hits 351 351
- Misses 9180 9190 +10
Partials 24 24
Continue to review full report at Codecov.
|
|
I merged #1874 . I think it would be helpful if you could rebase on |
maskaravivek
force-pushed
the
fixLogout
branch
from
4e511c2
to
33610d7
Compare
|
@misaochan I have rebased the PR. |
|
Test 1: Logged out of Misaochan (2FA) into Misaochan2 (non-2FA). Wikidata edit succeeds as usual. Test 2: Logged out of Misaochan2 and into Misaochan.
Conclusion:
All tests on Android 8.0 on Samsung Galaxy s7 device. Error 1: Error 2: |
|
@misaochan Thanks for testing the PR. :) Both the error look to be related to flaky or no internet. We should surely handle these cases and I am sure there are other cases that needs handling too. For eg. if I launch the app with flight mode enabled, the app immediately crashes instead of handling it gracefully. |
|
I agree, the crashes look unrelated. Will merge this as soon as you get global OATH permissions and can verify the edits work for you too. |
neslihanturan
approved these changes
Sep 4, 2018
|
@neslihanturan We need you to test that your Nearby uploads actually edit Wikidata p18 with this, after logging out and in. Not for crashes. |
|
Edit: Talked to Neslihan, unavoidable issues with her VPN. I will merge, and pray really hard that it works. ;) |
maskaravivek
added a commit
that referenced
this pull request
Sep 7, 2018
* Add Traceur for getting meaningful RxJava stack traces (#1832) * Hotfix for overwrite issue in 2.8.0 (#1838) * This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible. * Check if file title includes an extension already, by checking if is there any dot in it. * Fix logic error * Add uncovered tests * Remove unecessary line breaks * Make Javadocs more explicit * Versioning and changelog for v2.8.2 (#1842) * Versioning for v2.8.2 * Changelog for v2.8.2 * Add logs in wiki data edit and session refresh flow (#1874) * Fix logout (#1875) * [WIP] Refactor feedback and quiz to reduce possibility of NPE (#1881) * Refactor feedback and quiz to reduce possibility of NPE * Handle throwables in quiz checker * Minor refactoring * Set Traceur to only work in DEBUG mode (#1884) * Bug fix for uploaded images count in achievements activity (#1885) * Versioning and changelog for v2.8.3 (#1886) * Update changelog.md * Versioning for v2.8.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title (required)
Fixes issue where the uploads were attributed to a different account on logging out
Description (required)
As mentioned in #1866 on logging out, the next upload was being attributed to a different account. I investigated and found out that the
authCookiewasn't getting cleared on logging out. This PR handles the log out more gracefully.Tests performed (required)
I didn't upload pictures from both the accounts but have verified that the
authCookieis up to date when a fresh login occurs. I switched betweenTestmaskaraandMaskaravivekin the same session and found that the cookies were set correctly.@misaochan With this fix can you also try making a wiki data edit with a 2FA enabled account. I am hoping that the failures would be less frequent(There's one scenario that I mentioned in #1874 that is still not handled).