enable unusedFunction #1878

0x41head · 2024-02-18T17:51:27Z

adeebshihadeh · 2024-02-18T18:35:15Z

tests/misra/suppressions.txt

@@ -15,6 +15,9 @@ unmatchedSuppression
 # All interrupt handlers are defined, including ones we don't use
 unusedFunction:*/interrupt_handlers*.h

+# REGISTER_INTERRUPT defined in interrupt_handlers.h
+unknownMacro:*/gmlan_alt.h


why does this fix it?

used this to suppress the unknownMacro error that was being generated. Nothing to do with the unusedFunction error. Need to figure out if this is a false positive.

adeebshihadeh · 2024-02-18T19:05:22Z

tests/misra/test_misra.sh

-#printf "\n${GREEN}** UNUSED ALL CODE **${NC}\n"
-#cppcheck --enable=unusedFunction --quiet $PANDA_DIR/board/
+printf "\n${GREEN}** UNUSED ALL CODE **${NC}\n"
+cppcheck --enable=unusedFunction --quiet $PANDA_DIR/board/main.c 


hmm, also not sure how this works now. it needs to also analyze the bootstub and jungle builds

Seems like a bug from cppchecker's side. All the unused function seems to have been be generated by board/main.c as we can see in previous CI runs.
Running cppcheck $PANDA_OPTS -DSTM32H7 -DUID_BASE $PANDA_DIR/board/main.c $PANDA_DIR/board/jungle/main.c $PANDA_DIR/board/jungle/bootstub.c also seems to remove the unused function error ( it also adds another unknownMacro error )

adeebshihadeh · 2024-02-18T19:07:46Z

We should also add a test case for unusedFunction here since it takes a very unique code path.

panda/tests/misra/test_mutation.py

Line 38 in 00fab5e

patterns = [

adeebshihadeh · 2024-02-19T18:32:04Z

Not sure how the new test case is passing. It didn't catch either of these:

batman:panda$ git diff .
diff --git a/board/bootstub.c b/board/bootstub.c
index aee665e7..16d18903 100644
--- a/board/bootstub.c
+++ b/board/bootstub.c
@@ -28,6 +28,10 @@ void fail(void) {
   soft_flasher_start();
 }

+void abc(void) {
+
+}
+
 // know where to sig check
 extern void *_app_start[];

diff --git a/board/main.c b/board/main.c
index 061a9138..37f6c236 100644
--- a/board/main.c
+++ b/board/main.c
@@ -32,6 +32,10 @@

 // ********************* Serial debugging *********************

+void unusedfunction(void) {
+
+}
+
 bool check_started(void) {
   bool started = current_board->check_ignition() || ignition_can;
   ignition_seen |= started;

0x41head · 2024-02-20T11:56:25Z

hmm.. defining pre-processor symbols like seems to invoke the unusedFunction error.
cppcheck --enable=unusedFunction --quiet -DSTM32F4 -DUID_BASE -DPANDA -DSTM32H7 $PANDA_DIR/board/

Any particular reason you undefined it @adeebshihadeh ?

Log:

/home/aryan/Desktop/open-source/panda/board/jungle/main.c:169:3: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_INTERRUPT is a macro then please configure it. [unknownMacro]
  REGISTER_INTERRUPT(TICK_TIMER_IRQ, tick_handler, 10U, FAULT_INTERRUPT_RATE_TICK)
  ^
/home/aryan/Desktop/open-source/panda/board/drivers/can_common.h:200:0: style: The function 'can_set_forwarding' is never used. [unusedFunction]
void can_set_forwarding(uint8_t from, uint8_t to) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:71:0: style: The function 'gpio_set_all_output' is never used. [unusedFunction]
void gpio_set_all_output(const gpio_t *pins, uint8_t num_pins, bool enabled) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:77:0: style: The function 'gpio_set_bitmask' is never used. [unusedFunction]
void gpio_set_bitmask(const gpio_t *pins, uint8_t num_pins, uint32_t bitmask) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/uart.h:154:0: style: The function 'putui' is never used. [unusedFunction]
void putui(uint32_t i) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/watchdog.h:10:0: style: The function 'watchdog_init' is never used. [unusedFunction]
void watchdog_init(WatchdogTimeout timeout) {
^
/home/aryan/Desktop/open-source/panda/board/main.c:35:0: style: The function 'test' is never used. [unusedFunction]
void test(void) {}
^
/home/aryan/Desktop/open-source/panda/board/safety.h:110:0: style: The function 'gen_crc_lookup_table_16' is never used. [unusedFunction]
void gen_crc_lookup_table_16(uint16_t poly, uint16_t crc_lut[]) {
^
/home/aryan/Desktop/open-source/panda/board/safety/safety_hyundai_common.h:90:0: style: The function 'hyundai_common_canfd_compute_checksum' is never used. [unusedFunction]
uint32_t hyundai_common_canfd_compute_checksum(const CANPacket_t *to_push) {
^
/home/aryan/Desktop/open-source/panda/board/stm32h7/lldac.h:1:0: style: The function 'dac_init' is never used. [unusedFunction]
void dac_init(DAC_TypeDef *dac, uint8_t channel, bool dma) {
^
/home/aryan/Desktop/open-source/panda/board/stm32h7/lldac.h:30:0: style: The function 'dac_set' is never used. [unusedFunction]
void dac_set(DAC_TypeDef *dac, uint8_t channel, uint32_t value) {

adeebshihadeh · 2024-02-20T15:41:49Z

H7 and F4 should be mutually exclusive.

0x41head · 2024-02-20T17:10:39Z

cppcheck --enable=unusedFunction --quiet -DUID_BASE -DPANDA -DSTM32F4 $PANDA_DIR/board/main.c generates

/home/aryan/Desktop/open-source/panda/board/jungle/main.c:169:3: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_INTERRUPT is a macro then please configure it. [unknownMacro]
  REGISTER_INTERRUPT(TICK_TIMER_IRQ, tick_handler, 10U, FAULT_INTERRUPT_RATE_TICK)
  ^
/home/aryan/Desktop/open-source/panda/board/bootstub_declarations.h:16:0: style: The function 'uart_init' is never used. [unusedFunction]
void uart_init(uart_ring *q, int baud) { UNUSED(q); UNUSED(baud); }
^
/home/aryan/Desktop/open-source/panda/board/drivers/can_common.h:200:0: style: The function 'can_set_forwarding' is never used. [unusedFunction]
void can_set_forwarding(uint8_t from, uint8_t to) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:71:0: style: The function 'gpio_set_all_output' is never used. [unusedFunction]
void gpio_set_all_output(const gpio_t *pins, uint8_t num_pins, bool enabled) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:77:0: style: The function 'gpio_set_bitmask' is never used. [unusedFunction]
void gpio_set_bitmask(const gpio_t *pins, uint8_t num_pins, uint32_t bitmask) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/uart.h:154:0: style: The function 'putui' is never used. [unusedFunction]
void putui(uint32_t i) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/watchdog.h:10:0: style: The function 'watchdog_init' is never used. [unusedFunction]
void watchdog_init(WatchdogTimeout timeout) {
^
/home/aryan/Desktop/open-source/panda/board/main.c:34:0: style: The function 'test' is never used. [unusedFunction]
void test(void){}
^
/home/aryan/Desktop/open-source/panda/board/safety.h:110:0: style: The function 'gen_crc_lookup_table_16' is never used. [unusedFunction]
void gen_crc_lookup_table_16(uint16_t poly, uint16_t crc_lut[]) {
^
/home/aryan/Desktop/open-source/panda/board/safety/safety_hyundai_common.h:90:0: style: The function 'hyundai_common_canfd_compute_checksum' is never used. [unusedFunction]
uint32_t hyundai_common_canfd_compute_checksum(const CANPacket_t *to_push) {
^
/home/aryan/Desktop/open-source/panda/board/stm32fx/lluart.h:48:0: style: The function 'uart_send_break' is never used. [unusedFunction]
void uart_send_break(uart_ring *u) {
^
/home/aryan/Desktop/open-source/panda/board/stm32fx/lluart.h:81:0: style: The function 'USART2_IRQ_Handler' is never used. [unusedFunction]
void USART2_IRQ_Handler(void) { uart_interrupt_handler(&uart_ring_debug); }

cppcheck --enable=unusedFunction --quiet -DUID_BASE -DPANDA -DSTM32H7 $PANDA_DIR/board/ generates

** UNUSED ALL CODE **
/home/aryan/Desktop/open-source/panda/board/jungle/main.c:169:3: error: There is an unknown macro here somewhere. Configuration is required. If REGISTER_INTERRUPT is a macro then please configure it. [unknownMacro]
  REGISTER_INTERRUPT(TICK_TIMER_IRQ, tick_handler, 10U, FAULT_INTERRUPT_RATE_TICK)
  ^
/home/aryan/Desktop/open-source/panda/board/drivers/can_common.h:200:0: style: The function 'can_set_forwarding' is never used. [unusedFunction]
void can_set_forwarding(uint8_t from, uint8_t to) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:71:0: style: The function 'gpio_set_all_output' is never used. [unusedFunction]
void gpio_set_all_output(const gpio_t *pins, uint8_t num_pins, bool enabled) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/gpio.h:77:0: style: The function 'gpio_set_bitmask' is never used. [unusedFunction]
void gpio_set_bitmask(const gpio_t *pins, uint8_t num_pins, uint32_t bitmask) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/uart.h:154:0: style: The function 'putui' is never used. [unusedFunction]
void putui(uint32_t i) {
^
/home/aryan/Desktop/open-source/panda/board/drivers/watchdog.h:10:0: style: The function 'watchdog_init' is never used. [unusedFunction]
void watchdog_init(WatchdogTimeout timeout) {
^
/home/aryan/Desktop/open-source/panda/board/main.c:34:0: style: The function 'test' is never used. [unusedFunction]
void test(void){}
^
/home/aryan/Desktop/open-source/panda/board/stm32h7/lldac.h:1:0: style: The function 'dac_init' is never used. [unusedFunction]
void dac_init(DAC_TypeDef *dac, uint8_t channel, bool dma) {
^
/home/aryan/Desktop/open-source/panda/board/stm32h7/lldac.h:30:0: style: The function 'dac_set' is never used. [unusedFunction]
void dac_set(DAC_TypeDef *dac, uint8_t channel, uint32_t value) {
^

I guess we can add both cases to our misra tests since they generate slightly different results.

0x41head added 8 commits February 8, 2024 16:00

fixed uninitialized data error

5b5ad4f

Merge branch 'master' of https://github.com/commaai/panda

1ded177

Merge branch 'master' of https://github.com/commaai/panda

7d65226

Merge branch 'master' of https://github.com/commaai/panda

6e43a5c

Merge branch 'master' of https://github.com/commaai/panda

d2a6765

fix for unusedFunction

bc1c597

remove other changes

b87ccdc

remove check-library

9e0c80f

adeebshihadeh reviewed Feb 18, 2024

View reviewed changes

works locally

2df6f1d

0x41head added 5 commits February 23, 2024 15:00

improvements

de1b0f7

minor bug

1e64785

works locally

a259f71

mutation test fix

d9cb201

increase timeout for test_misra

5d14870

0x41head requested a review from adeebshihadeh February 24, 2024 11:05

Merge branch 'master' of github.com:commaai/panda into unusedFunction

64b8479

dzid26 mentioned this pull request May 25, 2024

Finish MISRA coverage #1794

Closed

dzid26 mentioned this pull request Jun 4, 2024

Enable unusedFunction checks #1970

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable unusedFunction #1878

enable unusedFunction #1878

0x41head commented Feb 18, 2024

adeebshihadeh Feb 18, 2024

0x41head Feb 18, 2024

adeebshihadeh Feb 18, 2024

0x41head Feb 18, 2024

adeebshihadeh commented Feb 18, 2024

adeebshihadeh commented Feb 19, 2024

0x41head commented Feb 20, 2024

adeebshihadeh commented Feb 20, 2024

0x41head commented Feb 20, 2024

enable unusedFunction #1878

Are you sure you want to change the base?

enable unusedFunction #1878

Conversation

0x41head commented Feb 18, 2024

adeebshihadeh Feb 18, 2024

Choose a reason for hiding this comment

0x41head Feb 18, 2024

Choose a reason for hiding this comment

adeebshihadeh Feb 18, 2024

Choose a reason for hiding this comment

0x41head Feb 18, 2024

Choose a reason for hiding this comment

adeebshihadeh commented Feb 18, 2024

adeebshihadeh commented Feb 19, 2024

0x41head commented Feb 20, 2024

adeebshihadeh commented Feb 20, 2024

0x41head commented Feb 20, 2024