Chrysler: Safety mode for Compact US Wide #1760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Releasing from draft, ready for review. This is safety-complete, but driving experience isn't great because the CUSW steering rack will sometimes fault when being slammed down to zero torque instantly on disengage. Per our Discord conversation back in February, I'm working on something to allow torque to fall at MAX_RATE_DOWN when disengaging. It's going to be a tricky change to critical code. It deserves its own PR, and can't come in first due to CI coverage tests. I propose to bring CUSW safety in now, gated under ALLOW_DEBUG like we'd probably start with anyway, and come back for the disengagement fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit from ALLOW_DEBUG(to be done by comma after initial merge)Accommodate torque ramp-down on disengage(will do this in another PR)