Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrysler longitudinal #1719

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

chrysler longitudinal #1719

wants to merge 11 commits into from

Conversation

gregjhogan
Copy link
Member

@gregjhogan gregjhogan commented Nov 12, 2023 •
edited
Loading

TODO:

  • limit for DAS_3.ENGINE_TORQUE_REQUEST
  • limit for DAS_3.ACC_DECEL
  • tests

@gregjhogan gregjhogan marked this pull request as ready for review November 13, 2023 04:45
@gregjhogan gregjhogan force-pushed the chrysler-long branch 4 times, most recently from ae8df79 to b3ea2ca Compare November 27, 2023 18:24
@gregjhogan gregjhogan force-pushed the chrysler-long branch 3 times, most recently from 1a9442f to 055b09e Compare December 6, 2023 04:36
@gregjhogan gregjhogan force-pushed the chrysler-long branch 2 times, most recently from 431f8b8 to f4cfd3d Compare December 25, 2023 23:28
sshane
sshane reviewed Jan 3, 2024
View reviewed changes
tests/safety/test_chrysler.py Outdated Show resolved Hide resolved
board/safety/safety_chrysler.h Outdated Show resolved Hide resolved
@sshane
Copy link
Contributor

sshane commented Apr 20, 2024 •
edited
Loading

I don't have enough time to fully review, but this PR looks quite large. Is there anything that can be split out, such as the rx check macro refactor? That would make things quicker to review, hard to know what is required and what is part of a clean up.

If that's the case and it's split out, then we could easily see what was added in the diff.

@gregjhogan
Copy link
Member Author

There are probably several PRs you could split this up into (RX checks and essentially 3 sub-platforms). This has been open so long now that I am also guessing there are other general improvements I am unaware of that need to be incorporated, too. If this isn't mergeable and you find time to work on this maybe you just want to create new PRs and use this one as a reference. I probably won't have time to in the near future, but the tests should be quite good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregjhogan @sshane