Kernel driver #16
Merged
Kernel driver #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geohot
reviewed
Jun 22, 2017
| @@ -0,0 +1,612 @@ | |||
| /** | |||
| * @file panda.c | |||
| * @author Jeddy Diamond Exum | |||
| @@ -0,0 +1,2 @@ | |||
| all: | |||
There was a problem hiding this comment.
Can we move this to driver/linux/test
| @@ -0,0 +1,6 @@ | |||
| .*.cmd | |||
There was a problem hiding this comment.
Can we move this to driver/linux/
Expecting a windows driver soon
|
|
||
| module_usb_driver(panda_usb_driver); | ||
|
|
||
| MODULE_LICENSE("GPL"); |
There was a problem hiding this comment.
Any issue with "Dual MIT/GPL"?
There was a problem hiding this comment.
Code largely influenced by an existing kernel driver. GPL is likely required.
| return -ENOMEM; | ||
| } | ||
|
|
||
| usb_fill_int_urb(urb, priv_dev->udev, |
There was a problem hiding this comment.
Can we call panda_usb_read_int_callback to trigger this to avoid copied code?
| usb_rcvintpipe(priv_dev->udev, 1), | ||
| urb->transfer_buffer, PANDA_USB_RX_BUFF_SIZE, | ||
| panda_usb_read_int_callback, priv_dev, 5); | ||
|
|
There was a problem hiding this comment.
Does URB_NO_TRANSFER_DMA_MAP have to be set here? If not, why is it set for the first usb_fill_int_urb?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the Panda Kernel Driver.
Works with all 3 CNA interfaces of the Panda.
Passes workbench test of panda to panda communication.