Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uds: server emulation and tests #1329

Draft
wants to merge 75 commits into
base: master
Choose a base branch
from
Draft

uds: server emulation and tests #1329

wants to merge 75 commits into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Apr 5, 2023 •
edited
Loading

sshane added 30 commits March 31, 2023 12:12
@sshane
Revert "Revert "IsoTpMessage: check CAN frame length (#1312)""
41ed480 
This reverts commit 09fee3e.
@sshane
need to pad for the check to work
679ee4a
@sshane
pass rx_offset up from can client
e683f84
@sshane
detect from internal can_client and just use it for the checks
cc28404
@sshane
move
70288a1
@sshane
test UDS
8a26f24
@sshane
AssertionError: isotp - rx: invalid CAN frame length: 7
bd0da30
@sshane
parameterized
2fbbf10
@sshane
use UdsClient
d9e1a2a
@sshane
Merge remote-tracking branch 'upstream/master' into uds-tests
275ffda
@sshane
clean up
52d283c
@sshane
try to do fw (draft)
809d945
@sshane
it works!!
f0bcc2e
@sshane
comments
f99ea30
@sshane
woah, found a bug with the tests!
00b26c6
@sshane
stash so far
9a0bd69
@sshane
draft
abfefcd
@sshane
draft
90f0e1e
@sshane
clean up
ba552a4
@sshane
clean up more
b934826
@sshane
add comment
f14b2eb
@sshane
remove prints
28903c1
@sshane
fixes
fc76a79
@sshane
revert fixes
17f7c0f
@sshane
revert fixes
71ba994
@sshane
skip
5c1779d
@sshane
call it a mock can buffer
3046a92
@sshane
caps
b5a10c2
@sshane
fix and can clean that up
43bcfb8
@sshane
no debug
ff4de7d
@sshane sshane mentioned this pull request Aug 30, 2023
Closed
@sshane sshane changed the title UdsServer thread uds: server emulation and tests Aug 30, 2023
@sshane sshane mentioned this pull request Aug 30, 2023
Merged
@sshane sshane mentioned this pull request Jul 31, 2024
Merged
@adeebshihadeh
Copy link
Contributor

Still useful or let's close?

@sshane
Copy link
Contributor Author

sshane commented Aug 27, 2024 •
edited
Loading

This is still very useful, as it caught a few bugs while writing (and would have also caught a recent bug in openpilot). It requires a day/few days of work to make it clean and mergable though

@sshane sshane marked this pull request as draft August 27, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregjhogan gregjhogan gregjhogan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshane @adeebshihadeh @gregjhogan