Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN Longitudinal: Enable for Camera SCC cars #1107

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Oct 15, 2022

openpilot longitudinal control support for CAN-based HKG cars that have the following messages send from the car on bus 2:

  • SCC11
  • SCC12
  • SCC13
  • SCC14
  • FCA11
  • FCA12

Currently with 2022 Hyundai Kona EV, without radar disable. As the messages send from the car on bus 2, we block the messages and send our own longitudinal commands to bus 0.

FCA11 and FCA12 do stock FCW and AEB, and are forwarded from the LKAS camera to the car.

Prerequisite of

Related

Thanks to community Kona EV 2022 owner Zack1010OP.

@adeebshihadeh
Copy link
Contributor

Can you write a test case for these in tests/safety/test_hyundai.py?

@sunnyhaibin
Copy link
Contributor Author

Can you write a test case for these in tests/safety/test_hyundai.py?

I could attempt it in the next coming days.

@sunnyhaibin sunnyhaibin marked this pull request as ready for review September 25, 2024 06:18
@sunnyhaibin
Copy link
Contributor Author

Can you write a test case for these in tests/safety/test_hyundai.py?

Unite test updated and all passed.

@sunnyhaibin sunnyhaibin changed the title Hyundai: Longitudinal support for CAN-based Camera SCC cars Hyundai CAN Longitudinal: Enable for Camera SCC cars Sep 27, 2024
@@ -792,6 +792,11 @@ def test_tx_hook_on_wrong_safety_mode(self):
if attr.startswith('TestHonda'):
# exceptions for common msgs across different hondas
tx = list(filter(lambda m: m[0] not in [0x1FA, 0x30C, 0x33D, 0x33DB], tx))

# TODO: Temporary, should be fixed in panda firmware, safety_hyundai.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no TODO?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants