Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai: enforce ACC main state with controls allowed #1054

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Aug 31, 2022

Enforce ACC main state with stock/openpilot longitudinal control in openpilot and panda safety. Enforce controls_allowed = 0 when the signal is 0.

Stock ACC: SCC11|MainMode_ACC

openpilot ACC: EMS16|CRUISE_LAMP_M

  • Available on all currently supported openpilot longitudinal HKG cars
  • Sync with ACC MAIN button press
  • Will be copied and sent with SCC11|MainMode_ACC to the car when ACC MAIN is pressed

Prerequisite of:

@sunnyhaibin
Copy link
Contributor Author

Upon testing on some older models, the signal does not do anything when the CRUISE MAIN button is pressed. Need to investigate and see if there is another common signal to use for those cars.

@sunnyhaibin sunnyhaibin marked this pull request as draft October 3, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant