Hotspot issue #530
Closed
Hotspot issue #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4239519.
merge to latest
|
Looks like this should be more of a GitHub issue and not a pull request. |
|
@vanillagorillaa yeah i should have i just modify the code not sure which is valid though. |
|
Closing this PR for now. |
This was referenced Feb 15, 2019
Closed
Closed
pd0wm
pushed a commit
that referenced
this pull request
May 9, 2020
869f123 Hyundai: counter check (#530) a439071 gitignore for route logs ac1b64e Fix CAN Ignition for Black Panda and Uno (#526) 273e388 When initializing all the CAN busses, make sure the are also cleared (#527) c2bea78 Fix python library on Windows (#523) 0a123b1 that too ba6355d unused lines c9102c0 Chrysler: use can packer in safety tests (#522) 9874e73 Abstract steering safety tests for Toyota and Chrysler (#520) 2299ecf Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515) 3517306 Subaru: fix steer torque scaling (#501) 0bc864b Make torque-based steering state global (#518) d9355c4 Make cruise_engaged_prev a global + test case for it (#519) 2115376 Abstract sample speed test (#516) 11dc905 remove unused function e5a586e Abstract gas interceptor tests (#517) 1dbed65 Safety Test Refactor: Honda (#495) 0632710 base class for different panda safety tests bd98fe6 safety tests: use shorter function name ba59ada No ESP in non-white (#514) c333618 Fix the CAN init fix (#513) 884afa0 Safety Test Refactor: Chrysler and Volkswagen PQ (#508) d77b72d Safety Test Refactor: Nissan (#510) 4c7755c Match Panda DFU entry fix in "make recover" process (#509) 0336f62 Pedal gas pressed safety limits (#507) 715b1a1 Hyundai-Kia-Genesis (HKG) (#503) 6f105e8 Safety Test Refactor: Subaru (#502) 57cc954 Safety Test Refactor: GM (#504) dd01c3b Safety Test Refactor: Hyundai (#505) 592c2c8 add support to can_unique.py for Cabana CSV format. (#506) ccf13b7 No more infinite while loops in CAN init (#499) 6c442b4 Safety Test Refactor: Volkswagen MQB (#493) f07a6ee panda recover should go through bootstub first (#498) 8cc3a35 remove cadillac (#496) 62e4d3c Chrysler: fix missing button signal on TX (#490) abce8f3 Safety Test Refactor: Toyota + support code (#491) 500370a Make sure relay faults make it to the health packet (#492) bc90b60 toyota: use universal gas pressed bit (#488) 74d10cc Fixed possible race condition (#487) a05361e cleanup safety_replay dockerfile (#486) fe73dcc Openpilot-tools is deprecated (#484) da8e00f TX message guaranteed delivery (#421) d8f6184 Add ISO number for longitudinal limits flag comment 6a60b78 touch ups 2ce6536 comments on unsafe flags d880134 remove from there as well 055ea07 remove that unsafe flag since it isn't implemented and it's unclear how to 4e98bbe Apply unsafe allow gas mode to all cars. (#480) 0c2c149 Fixing libusb busy error (#174) 753c42c Update Board Mac SDK Install script to work on clean mac (#146) b9a9ea3 Unsafe gas disengage mods, fix test compile warning (#481) 08ef92d Safety model for Volkswagen PQ35/PQ46/NMS (#474) 51e0a55 Support code for unsafe mode unit tests (#478) 5325b62 current_safety_mode 7908b72 update updating unsafe mode 98503e8 disable stock honda AEB in unsafe mode (#477) 01b2ccb one more 9a30265 weak steering while not engaged 577f10b added options for unsafe mode 83cf7bf update comment 4556e74 enable unsafe mode, toggle for use by forks that so choose de89fcd Nissan leaf (#473) git-subtree-dir: panda git-subtree-split: 869f123
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
869f123 Hyundai: counter check (#530) a439071 gitignore for route logs ac1b64e Fix CAN Ignition for Black Panda and Uno (#526) 273e388 When initializing all the CAN busses, make sure the are also cleared (#527) c2bea78 Fix python library on Windows (#523) 0a123b1 that too ba6355d unused lines c9102c0 Chrysler: use can packer in safety tests (#522) 9874e73 Abstract steering safety tests for Toyota and Chrysler (#520) 2299ecf Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515) 3517306 Subaru: fix steer torque scaling (#501) 0bc864b Make torque-based steering state global (#518) d9355c4 Make cruise_engaged_prev a global + test case for it (#519) 2115376 Abstract sample speed test (#516) 11dc905 remove unused function e5a586e Abstract gas interceptor tests (#517) 1dbed65 Safety Test Refactor: Honda (#495) 0632710 base class for different panda safety tests bd98fe6 safety tests: use shorter function name ba59ada No ESP in non-white (#514) c333618 Fix the CAN init fix (#513) 884afa0 Safety Test Refactor: Chrysler and Volkswagen PQ (#508) d77b72d Safety Test Refactor: Nissan (#510) 4c7755c Match Panda DFU entry fix in "make recover" process (#509) 0336f62 Pedal gas pressed safety limits (#507) 715b1a1 Hyundai-Kia-Genesis (HKG) (#503) 6f105e8 Safety Test Refactor: Subaru (#502) 57cc954 Safety Test Refactor: GM (#504) dd01c3b Safety Test Refactor: Hyundai (#505) 592c2c8 add support to can_unique.py for Cabana CSV format. (#506) ccf13b7 No more infinite while loops in CAN init (#499) 6c442b4 Safety Test Refactor: Volkswagen MQB (#493) f07a6ee panda recover should go through bootstub first (#498) 8cc3a35 remove cadillac (#496) 62e4d3c Chrysler: fix missing button signal on TX (#490) abce8f3 Safety Test Refactor: Toyota + support code (#491) 500370a Make sure relay faults make it to the health packet (#492) bc90b60 toyota: use universal gas pressed bit (#488) 74d10cc Fixed possible race condition (#487) a05361e cleanup safety_replay dockerfile (#486) fe73dcc Openpilot-tools is deprecated (#484) da8e00f TX message guaranteed delivery (#421) d8f6184 Add ISO number for longitudinal limits flag comment 6a60b78 touch ups 2ce6536 comments on unsafe flags d880134 remove from there as well 055ea07 remove that unsafe flag since it isn't implemented and it's unclear how to 4e98bbe Apply unsafe allow gas mode to all cars. (#480) 0c2c149 Fixing libusb busy error (#174) 753c42c Update Board Mac SDK Install script to work on clean mac (#146) b9a9ea3 Unsafe gas disengage mods, fix test compile warning (#481) 08ef92d Safety model for Volkswagen PQ35/PQ46/NMS (#474) 51e0a55 Support code for unsafe mode unit tests (#478) 5325b62 current_safety_mode 7908b72 update updating unsafe mode 98503e8 disable stock honda AEB in unsafe mode (#477) 01b2ccb one more 9a30265 weak steering while not engaged 577f10b added options for unsafe mode 83cf7bf update comment 4556e74 enable unsafe mode, toggle for use by forks that so choose de89fcd Nissan leaf (#473) git-subtree-dir: panda git-subtree-split: 869f123
pd0wm
pushed a commit
that referenced
this pull request
May 10, 2020
869f123 Hyundai: counter check (#530) a439071 gitignore for route logs ac1b64e Fix CAN Ignition for Black Panda and Uno (#526) 273e388 When initializing all the CAN busses, make sure the are also cleared (#527) c2bea78 Fix python library on Windows (#523) 0a123b1 that too ba6355d unused lines c9102c0 Chrysler: use can packer in safety tests (#522) 9874e73 Abstract steering safety tests for Toyota and Chrysler (#520) 2299ecf Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515) 3517306 Subaru: fix steer torque scaling (#501) 0bc864b Make torque-based steering state global (#518) d9355c4 Make cruise_engaged_prev a global + test case for it (#519) 2115376 Abstract sample speed test (#516) 11dc905 remove unused function e5a586e Abstract gas interceptor tests (#517) 1dbed65 Safety Test Refactor: Honda (#495) 0632710 base class for different panda safety tests bd98fe6 safety tests: use shorter function name ba59ada No ESP in non-white (#514) c333618 Fix the CAN init fix (#513) 884afa0 Safety Test Refactor: Chrysler and Volkswagen PQ (#508) d77b72d Safety Test Refactor: Nissan (#510) 4c7755c Match Panda DFU entry fix in "make recover" process (#509) 0336f62 Pedal gas pressed safety limits (#507) 715b1a1 Hyundai-Kia-Genesis (HKG) (#503) 6f105e8 Safety Test Refactor: Subaru (#502) 57cc954 Safety Test Refactor: GM (#504) dd01c3b Safety Test Refactor: Hyundai (#505) 592c2c8 add support to can_unique.py for Cabana CSV format. (#506) ccf13b7 No more infinite while loops in CAN init (#499) 6c442b4 Safety Test Refactor: Volkswagen MQB (#493) f07a6ee panda recover should go through bootstub first (#498) 8cc3a35 remove cadillac (#496) 62e4d3c Chrysler: fix missing button signal on TX (#490) abce8f3 Safety Test Refactor: Toyota + support code (#491) 500370a Make sure relay faults make it to the health packet (#492) bc90b60 toyota: use universal gas pressed bit (#488) 74d10cc Fixed possible race condition (#487) a05361e cleanup safety_replay dockerfile (#486) fe73dcc Openpilot-tools is deprecated (#484) da8e00f TX message guaranteed delivery (#421) d8f6184 Add ISO number for longitudinal limits flag comment 6a60b78 touch ups 2ce6536 comments on unsafe flags d880134 remove from there as well 055ea07 remove that unsafe flag since it isn't implemented and it's unclear how to 4e98bbe Apply unsafe allow gas mode to all cars. (#480) 0c2c149 Fixing libusb busy error (#174) 753c42c Update Board Mac SDK Install script to work on clean mac (#146) b9a9ea3 Unsafe gas disengage mods, fix test compile warning (#481) 08ef92d Safety model for Volkswagen PQ35/PQ46/NMS (#474) 51e0a55 Support code for unsafe mode unit tests (#478) 5325b62 current_safety_mode 7908b72 update updating unsafe mode 98503e8 disable stock honda AEB in unsafe mode (#477) 01b2ccb one more 9a30265 weak steering while not engaged 577f10b added options for unsafe mode 83cf7bf update comment 4556e74 enable unsafe mode, toggle for use by forks that so choose de89fcd Nissan leaf (#473) git-subtree-dir: panda git-subtree-split: 869f123
pd0wm
pushed a commit
that referenced
this pull request
May 11, 2020
869f123 Hyundai: counter check (#530) a439071 gitignore for route logs ac1b64e Fix CAN Ignition for Black Panda and Uno (#526) 273e388 When initializing all the CAN busses, make sure the are also cleared (#527) c2bea78 Fix python library on Windows (#523) 0a123b1 that too ba6355d unused lines c9102c0 Chrysler: use can packer in safety tests (#522) 9874e73 Abstract steering safety tests for Toyota and Chrysler (#520) 2299ecf Block 0xe5 (Honda Bosch) at the panda/uno. Only allow static values. (#515) 3517306 Subaru: fix steer torque scaling (#501) 0bc864b Make torque-based steering state global (#518) d9355c4 Make cruise_engaged_prev a global + test case for it (#519) 2115376 Abstract sample speed test (#516) 11dc905 remove unused function e5a586e Abstract gas interceptor tests (#517) 1dbed65 Safety Test Refactor: Honda (#495) 0632710 base class for different panda safety tests bd98fe6 safety tests: use shorter function name ba59ada No ESP in non-white (#514) c333618 Fix the CAN init fix (#513) 884afa0 Safety Test Refactor: Chrysler and Volkswagen PQ (#508) d77b72d Safety Test Refactor: Nissan (#510) 4c7755c Match Panda DFU entry fix in "make recover" process (#509) 0336f62 Pedal gas pressed safety limits (#507) 715b1a1 Hyundai-Kia-Genesis (HKG) (#503) 6f105e8 Safety Test Refactor: Subaru (#502) 57cc954 Safety Test Refactor: GM (#504) dd01c3b Safety Test Refactor: Hyundai (#505) 592c2c8 add support to can_unique.py for Cabana CSV format. (#506) ccf13b7 No more infinite while loops in CAN init (#499) 6c442b4 Safety Test Refactor: Volkswagen MQB (#493) f07a6ee panda recover should go through bootstub first (#498) 8cc3a35 remove cadillac (#496) 62e4d3c Chrysler: fix missing button signal on TX (#490) abce8f3 Safety Test Refactor: Toyota + support code (#491) 500370a Make sure relay faults make it to the health packet (#492) bc90b60 toyota: use universal gas pressed bit (#488) 74d10cc Fixed possible race condition (#487) a05361e cleanup safety_replay dockerfile (#486) fe73dcc Openpilot-tools is deprecated (#484) da8e00f TX message guaranteed delivery (#421) d8f6184 Add ISO number for longitudinal limits flag comment 6a60b78 touch ups 2ce6536 comments on unsafe flags d880134 remove from there as well 055ea07 remove that unsafe flag since it isn't implemented and it's unclear how to 4e98bbe Apply unsafe allow gas mode to all cars. (#480) 0c2c149 Fixing libusb busy error (#174) 753c42c Update Board Mac SDK Install script to work on clean mac (#146) b9a9ea3 Unsafe gas disengage mods, fix test compile warning (#481) 08ef92d Safety model for Volkswagen PQ35/PQ46/NMS (#474) 51e0a55 Support code for unsafe mode unit tests (#478) 5325b62 current_safety_mode 7908b72 update updating unsafe mode 98503e8 disable stock honda AEB in unsafe mode (#477) 01b2ccb one more 9a30265 weak steering while not engaged 577f10b added options for unsafe mode 83cf7bf update comment 4556e74 enable unsafe mode, toggle for use by forks that so choose de89fcd Nissan leaf (#473) git-subtree-dir: panda git-subtree-split: 869f123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was chatting with VG regarding the issue so decided to send PR
I do understand the hotspot is defined by default IP for hotspot however not everyone have tethering plan which is blocked by provider however if you know ways around android you can still have tethering most common is using proxy where users don't have to do much as far as rooting the phone goes however only issue with that is just IP address is different which 192.168.49. except for 192.168.43. so probably add if statement for android for IP.
Other suggestion i had regarding same issue was probably add it ask APK option just in case for some reason the IP is different probably allow user to enter IP manually?