Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis GV70: add "without HDA II" to docs #32835

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Genesis GV70: add "without HDA II" to docs #32835

merged 2 commits into from
Jun 26, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jun 26, 2024

So the brochure doesn't say anything about HDA II for the 2022 or 2023, but a user's window sticker says that the sport prestige package (w/ 2.5T) does upgrade the car with it.

image

https://windowsticker.carvana.io/Hyundai_ws_id_67534e92-1f6d-11ef-93fe-5abb9a386739.pdf

https://www.genesis.com/content/dam/genesis/us/pdf/2022/2022-Genesis%20GV70%20Brochure_vfin.pdf

@sshane sshane changed the title Genesis GV70: add without HDA II to docs Genesis GV70: add "without HDA II" to docs Jun 26, 2024
@sshane sshane added docs car vehicle-specific hyundai labels Jun 26, 2024
@sshane sshane marked this pull request as ready for review June 26, 2024 00:07
Copy link
Contributor

github-actions bot commented Jun 26, 2024

⚠️ This PR makes changes to CARS.md ⚠️

🔀 Column Changes

Make Model Supported Package ACC No ACC accel below No ALC below Steering Torque Resume from stop Hardware Needed Video
Genesis GV70 (2.5T Trim) 2022-235 ➡️ GV70 (2.5T Trim, without HDA II) 2022-235 All Stock 0 mph 0 mph
Parts- 1 Hyundai L connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
➡️
Parts- 1 Hyundai L connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
Genesis GV70 (3.5T Trim) 2022-235 ➡️ GV70 (3.5T Trim, without HDA II) 2022-235 All Stock 0 mph 0 mph
Parts- 1 Hyundai M connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here
➡️
Parts- 1 Hyundai M connector
- 1 RJ45 cable (7 ft)
- 1 comma 3X
- 1 comma power v2
- 1 harness box
- 1 mount
- 1 right angle OBD-C cable (1.5 ft)
Buy Here

📖 Detail Sentence Changes

  • Sentence for Genesis GV70 (2.5T Trim) 2022-23 changed!
    - openpilot upgrades your <strong>Genesis GV70 (2.5T Trim)</strong> with automated lane centering <strong>at all speeds</strong>, and adaptive cruise control <strong>that automatically resumes from a stop</strong>.
    + openpilot upgrades your <strong>Genesis GV70 (2.5T Trim, without HDA II)</strong> with automated lane centering <strong>at all speeds</strong>, and adaptive cruise control <strong>that automatically resumes from a stop</strong>.
  • Sentence for Genesis GV70 (3.5T Trim) 2022-23 changed!
    - openpilot upgrades your <strong>Genesis GV70 (3.5T Trim)</strong> with automated lane centering <strong>at all speeds</strong>, and adaptive cruise control <strong>that automatically resumes from a stop</strong>.
    + openpilot upgrades your <strong>Genesis GV70 (3.5T Trim, without HDA II)</strong> with automated lane centering <strong>at all speeds</strong>, and adaptive cruise control <strong>that automatically resumes from a stop</strong>.

@sshane sshane merged commit 9a27512 into master Jun 26, 2024
14 checks passed
@sshane sshane deleted the gv70-no-hda2 branch June 26, 2024 00:19
HyundaiCarDocs("Genesis GV70 (3.5T Trim) 2022-23", "All", car_parts=CarParts.common([CarHarness.hyundai_m])),
# TODO: Hyundai P is likely the correct harness for HDA II for 2.5T (unsupported due to missing ADAS ECU, is that the radar?)
HyundaiCarDocs("Genesis GV70 (2.5T Trim, without HDA II) 2022-23", "All", car_parts=CarParts.common([CarHarness.hyundai_l])),
HyundaiCarDocs("Genesis GV70 (3.5T Trim, without HDA II) 2022-23", "All", car_parts=CarParts.common([CarHarness.hyundai_m])),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we make the HDA2 version of the 3.5T connector yet, user will need to re-pin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it the wrong harness that was shipped? The websites recommendation was to purchase connector L as it’s recommended for the 2022 GV70 2.5T. Being that it’s the sport prestige package, should the M connector work or the P connector?
If that is the case, how do I exchange for the correct one?
If a re-pin is needed and I need to utilize a different fork that supports it (SP/FP), are there instruction as to how to re-pin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it the wrong harness that was shipped? The websites recommendation was to purchase connector L as it’s recommended for the 2022 GV70 2.5T. Being that it’s the sport prestige package, should the M connector work or the P connector? If that is the case, how do I exchange for the correct one? If a re-pin is needed and I need to utilize a different fork that supports it (SP/FP), are there instruction as to how to re-pin?

It seems that you’ve missed the message I pinged you with on Discord. Instructions have been mentioned in my reply on Discord.

Copy link
Contributor Author

@sshane sshane Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A combination of both, likely wrong harness and there are differences with how the ECUs are structured that openpilot doesn't yet support.

Basically, we expect your car to have an ADAS ECU sending the lane following messages, but our firmware query returns nothing for the expected address.

You can try to ask for a return of the harness and then buy the Hyundai P, but you will still be on your own for software support for the time being. @sunnyhaibin has a PR for a similar car, so this may work: #31704

Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific docs hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants