Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN-FD: Universal gear checks #32732

Closed
wants to merge 1 commit into from

Conversation

sunnyhaibin
Copy link
Contributor

Description

The refactor's goal is to improve the gear checking logic to be applicable to both HDA2 and non-HDA2 Hyundai vehicles, which was previously only applied to non-HDA2 cars.

Verification

This is tested in the following active PRs:

@github-actions github-actions bot added car vehicle-specific hyundai labels Jun 13, 2024
Copy link
Contributor

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@sshane
Copy link
Contributor

sshane commented Jun 13, 2024

Both of these cars are peculiarly missing the ADAS ECU but have bus structures similar to HDA2 vehicles. Until we understand what's going on, I don't want to merge a change like this where we don't fully understand why it's needed.

@sshane sshane closed this Jun 13, 2024
@sunnyhaibin sunnyhaibin deleted the hkg-canfd-gear-check branch June 13, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific hyundai
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants