Change Ioniq 5 Southeast Asia only to Non-US only #32701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
|
can you also change the EV6? |
|
PR this is for: #32648 |
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
…aai#32701) * Update values.py * ev6 too is probably the same --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> old-commit-hash: 0319379
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm currently testing my 2024 Ioniq 5 (non-HDA/HDA2 trim) for compatibility, and so far, it looks promising. Based on the firmware versions, I have confirmed that my vehicle is the EU version. Despite having the ADAS ECU, there are no HDA/HDA2-related functionalities available.
I'm using the Hyundai Q connector for this testing. @sunnyhaibin recommended changing the "Southeast Asia only" label to "non-US only" as the EU version also utilizes the Q connector.