Hyundai CAN FD: fix spotty FW query without comma power #32627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
changed the title
|
thanks to @haram-KONA for his time spent lending his car for testing! |
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
bump old-commit-hash: a3d2d78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commaai/panda#1967 for what is exactly going on here.
Querying fwdCamera & fwdRadar on OBD port, then quickly switching to PT bus 1:
master: 1618132d68afc876/0000000c--c966bc8dce (each request is missing radar or camera or both)
this PR: 1618132d68afc876/0000000d--33b6b2e9ff (all requests have both radar and camera)
The above but a lot more requests per route:
master: 1618132d68afc876/00000008--a78cc51a8c
master: 1618132d68afc876/00000009--8c7533ceaf
this PR: 1618132d68afc876/0000000b--4dffacab79
TL;DR: messages sent while mux'd to the OBD2 port are stuck in the can core's hardware queue until we switch to the powertrain bus (bus 1 on HDA2 cars), at which point we send two first frames to the ECU since we didn't expect the message destined for the OBD2 port to stick around and end up sending.