Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GM Longitudinal: Display personality in instrument cluster #31801

Merged
merged 4 commits into from
Mar 11, 2024
Merged

GM Longitudinal: Display personality in instrument cluster #31801

merged 4 commits into from
Mar 11, 2024

Conversation

sunnyhaibin
Copy link
Contributor

Displays Longitudinal Personality with 1st, 2nd, and 3rd bar.

Requires

@github-actions github-actions bot added car vehicle-specific gm labels Mar 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

sshane
sshane reviewed Mar 10, 2024
View reviewed changes
selfdrive/car/gm/gmcan.py Outdated Show resolved Hide resolved
sunnyhaibin and others added 2 commits March 10, 2024 00:04
@sunnyhaibin @sshane
Correct value
ff9f89f 
Co-authored-by: Shane Smiskol <shane@smiskol.com>
@sunnyhaibin
Merge remote-tracking branch 'commaai/openpilot/master' into gm-gac-c…
fba6200 
…luster
@sunnyhaibin sunnyhaibin marked this pull request as ready for review March 10, 2024 05:06
@sshane
Copy link
Contributor

sshane commented Mar 10, 2024

@Verylukyguy can you try this?

@sshane sshane closed this Mar 10, 2024
@sshane sshane reopened this Mar 10, 2024
@sshane sshane closed this Mar 10, 2024
@sshane sshane reopened this Mar 10, 2024
@sshane sshane merged commit 3d7595d into commaai:master Mar 11, 2024
26 checks passed
@sunnyhaibin sunnyhaibin deleted the gm-gac-cluster branch March 11, 2024 20:31
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
@sunnyhaibin @sshane @cydia2020
GM Longitudinal: Display personality in instrument cluster (commaai#3…
9ba1b3a 
…1801)

* GM Longitudinal: Display personality in instrument cluster

* Correct value

Co-authored-by: Shane Smiskol <shane@smiskol.com>

* update refs

---------

Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshane sshane sshane left review comments

Assignees
No one assigned
Labels
car vehicle-specific enhancement gm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyhaibin @sshane