CI: use namespace.io #31064
Merged
CI: use namespace.io #31064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Jan 19, 2024
| @@ -181,7 +180,7 @@ jobs: | |||
| run: | | |||
| ${{ env.RUN }} "source selfdrive/test/setup_xvfb.sh && \ | |||
| export MAPBOX_TOKEN='pk.eyJ1Ijoiam5ld2IiLCJhIjoiY2xxNW8zZXprMGw1ZzJwbzZneHd2NHljbSJ9.gV7VPRfbXFetD-1OVF0XZg' && \ | |||
| $PYTEST --timeout 40 -m 'not slow' && \ | |||
| $PYTEST --timeout 40 -m 'not slow' -n $(nproc) && \ | |||
There was a problem hiding this comment.
why was this changed from auto only here?
There was a problem hiding this comment.
the pytest auto only returns 4 even though there are 8 cpus (perhaps something with hyperthreading or docker), im going to bring it up with the namespace people.
There was a problem hiding this comment.
-n auto returns physical cores, maybe there's just 4 hyperthreaded cores. (using logical cores still improves performance in our tests, so maybe we should switch to -n logical)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed the multiarch push, working on my fork: https://github.com/jnewb1/openpilot/actions/runs/7580004107