athenad: update comment about timeout constant #29216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
changed the title
|
I think it's just a typing issue, the type is defined conditionally: https://github.com/python/typeshed/blob/9456f5501b564b333891fb474f44f7172c6d5174/stdlib/_socket.pyi#L514 (maybe we could make mypy recognise this on linux, but supposedly it isn't available on macOS?) |
|
yeah only linux supports this TCP option, made a mypy PR (python/mypy#15811). we can ignore for now since we know what the issue is (if athenad is ran on macOS or PC I'd make a PR to not set option) |
sshane
force-pushed
the
user-timeout-in-socket
branch
from
8b2cafb to
7b7c949
Compare
sshane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mentioned it was exposed in 3.7 release notes, so not sure why we thought it wasn't available (checked a venv and it's there in 3.8.11)
related PR: #28864