Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added enum type for hudlane code in honda carcontroller #215

Closed
wants to merge 1 commit into from
Closed

Added enum type for hudlane code in honda carcontroller #215

wants to merge 1 commit into from

Conversation

whitef0x0
Copy link

@whitef0x0 whitef0x0 commented Mar 16, 2018 •
edited
Loading

This just completes a TODO I found in the honda/carcontroller file wrt to adding enums for hudlane codes.

@rbiasini
Copy link
Contributor

thanks @whitef0x0 , fortunately in the upcoming release we now use a CANpacker to generate can messages to send using the dbc file. Such change will address this PR as well, so I can close it.

@rbiasini rbiasini closed this Mar 16, 2018
@whitef0x0
Copy link
Author

@rbiasini do you have a list of starting issues/TODOs that would be helpful to work on instead?

pjlao307 pushed a commit to pjlao307/openpilot that referenced this pull request Apr 17, 2019
@arne182
Merge pull request commaai#215 from arne182/rectrafficsigns
97e3c4c 
Rectrafficsigns
xx979xx added a commit to xx979xx/openpilot that referenced this pull request Dec 7, 2019
@xx979xx
Merge pull request commaai#215 from SiGmAX666/HKG_6.5
b1db54e 
Complete add of Ioniq EV
pd0wm pushed a commit that referenced this pull request Feb 14, 2020
Squashed 'opendbc/' changes from d68f8ff0..d338b9fb
b8587fa 
d338b9fb Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: d338b9fba7a76eb5a4a2e3191d363c18a81646dc
pd0wm pushed a commit that referenced this pull request Feb 14, 2020
Squashed 'opendbc/' changes from d68f8ff0..d338b9fb
4dc88a4 
d338b9fb Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: d338b9fba7a76eb5a4a2e3191d363c18a81646dc
pd0wm pushed a commit that referenced this pull request Feb 16, 2020
Squashed 'opendbc/' changes from d68f8ff0c..fbbba94aa
b041327 
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: fbbba94aae1e992c42f6f106c18d898905e3e39b
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
e434277 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
822046b 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
5738bb5 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
ab3557e 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
14c7fca 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 18, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
e5d1737 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
pd0wm pushed a commit that referenced this pull request Feb 19, 2020
Squashed 'opendbc/' changes from d68f8ff0c..2ae0327ea
a2c6d03 
2ae0327ea GitHub actions (#217)
fbbba94aa GM: use common gear VALs
dacd8b460 Chrysler commonize gear VALs
d338b9fba Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (#215)

git-subtree-dir: opendbc
git-subtree-split: 2ae0327ea25db36227d52acfaae8927a59d4e5a3
debugged-tech pushed a commit to debugged-tech/DebuggedPilot that referenced this pull request Sep 17, 2020
@sshane
properly set unsafe_mode = 1 for UNSAFE_DISABLE_DISENGAGE_ON_GAS (com…
12b9608 
…maai#215)

* properly set unsafe_mode = 1 for UNSAFE_DISABLE_DISENGAGE_ON_GAS

* change log

* change safety param to better align STEER_TORQUE_EPS and STEER_TORQUE_CMD

* update version
debugged-tech pushed a commit to debugged-tech/DebuggedPilot that referenced this pull request Sep 25, 2020
@sshane
Support for 2020 Prius (commaai#220)
86190e8 
* add Prius 2020 from Trae

* add to DG

* add debugging

* Add PID tune for 2020 Prius

* don't reinit

* add sng hack for 2020 prius

* sng hack for all cars with smart dsu

* tune long and actuator delay for 2020 Prius

* tune safetyParam scale for 2020 Prius and add 2020 dbc from 17

* tune 2020 prius long and actuator delay

* tune actuator delay

* try this for derivative

* try 2

* temp

* rm

* remove commented INDI for 2020 Prius

* use zss steerRateCost tuning

* try 2 for TSS2 Corolla derivative

* remove steerActDelay from TSS2 Corolla PID

* tune d

* these can be zeros

* remove

* 16% less gas for 2020 Prius

* steer actuator delay

* revert

* 2020 Prius uses INDI if not ZSS

* less gas and tune wheelbase

* revert to default steerRateCost

* move to ret.smartDsu

* use stock long tuning

* use param to toggle indi for 2020 Prius as well

* revert steerRateCost

* PI 0.4

* remove comment and make steer delay .55 for both tunes

* revert tss2 corolla tuning

* revert, 2020 prius has sng without pedal

* tune dg for 2020 Prius

* remove comment

* tune P

* revert dynamic gas

* comment out dg

* use param for sng hack, not smartDsu

* simplify

* tune

* properly set unsafe_mode = 1 for UNSAFE_DISABLE_DISENGAGE_ON_GAS (commaai#215) (commaai#235)

* properly set unsafe_mode = 1 for UNSAFE_DISABLE_DISENGAGE_ON_GAS

* change log

* change safety param to better align STEER_TORQUE_EPS and STEER_TORQUE_CMD

* update version

* Revert "properly set unsafe_mode = 1 for UNSAFE_DISABLE_DISENGAGE_ON_GAS (commaai#215) (commaai#235)"

This reverts commit 683a30b.

* update releases

* update releases
JMPZ11 added a commit to JMPZ11/openpilot that referenced this pull request Sep 29, 2020
@JMPZ11
Squashed 'opendbc/' changes from c0eba096..bdcd31df
0fea888 
bdcd31df reducing precision
1263500c scale is supposed to be 0-255
7c4d34a shorter scale, shift aftert scale
7971a608 maybe scale was too long
be5b34b7 fingers crossed 0-1 is the desired range...
27368e96 accidental dup
79fe914e Added Pedal entries
63540dd2 add interceptor
a1aa3b78 Cleanup of Nissan DBC (commaai#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (commaai#219)
2ae0327e GitHub actions (commaai#217)
fbbba94a GM: use common gear VALs
dacd8b46 Chrysler commonize gear VALs
d338b9fb Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (commaai#215)
d68f8ff0 Clean up .gitignore
e82757b9 Add Lexus NX300H (commaai#214)
745a2bb0 Removed non high voltage items. Added units.
fafd091a Added High Voltage Management to powertrain file.
15b6b316 Update subaru_global_2017.dbc
a12af19a Add steering error signal in subaru global
d411c175 correct max value
881c065d add electrical gear and fix driver torque
1bbac4b8 Add reference to CANdevStudio in README file
8f70ea01 Adds 2016 Honda CR-V Executive
5081966f One more fix
fa5dc680 Fix honda dbc files after steer torque addition
e4dfb2fa update honda steering signals (commaai#208)
53fc4487 added generator test (commaai#207)
cb27d6e3 Honda Nidec: add new ACC_HUD signals to all other cars other than the CIVIC
6e6779f9 build on mac AND linux, also gotta not use these python files
79dbfc1a build on mac
4f82d01e gitignore
5cb83454 Honda FCM: diagnostic signals
d309cdce Added linter to opendbc (commaai#203)
d452706f add requirements.txt
ec3b4595 deterministic dependency order
a265d351 Azure pipelines ci (commaai#202)
bce9a2e1 packer depends on libdbc
5d5fdd6a no more python version of libdbc, everything through cython
541705bf move CANDefine to parser code
da25c52a add test for can define
0ba7926b unify can packer and parser
25d88009 consistent naming
a5c640a5 fix linter
be210fef remove obsolete make file
ffd9dca7 opendbc needs cereal
b559f63d remove more make
d0929496 seems to work now
41e80836 don't make
3254d1fc think scons works
eb78f6aa scons sort of working
0ef1e35d fix gitignore
e155e017 Can migration (commaai#199)
3eded83a Honda: correct steering torque sensor sign to be consistent with standard convention (left+)
32f70e2f Fix outback endianness consistency (commaai#196)
a7da471f Update subaru_outback_2015_eyesight.dbc (commaai#195)

git-subtree-dir: opendbc
git-subtree-split: bdcd31dff8e38467281e1b0f865abe978b04d990
JMPZ11 added a commit to JMPZ11/openpilot that referenced this pull request Oct 11, 2020
@JMPZ11
Squashed 'opendbc/' changes from c0eba096..5eeb33c5
e647c3a 
5eeb33c5 Master pedal (#1)
63540dd2 add interceptor
a1aa3b78 Cleanup of Nissan DBC (commaai#218)
c1f76482 reverting changes to Chrysler: speed message seems different from car to car
2de8e9e8 Chrysler: Speed msg is 5 bytes
f4ac315e Chrysler: add counter to 514
0fb62cf8 Toyota Blind Spot Monitor (TSS2-only?) (commaai#219)
2ae0327e GitHub actions (commaai#217)
fbbba94a GM: use common gear VALs
dacd8b46 Chrysler commonize gear VALs
d338b9fb Add support for 2019 Civic Sedan Diesel. Split GAS_PEDAL_2 out to each car. (commaai#215)
d68f8ff0 Clean up .gitignore
e82757b9 Add Lexus NX300H (commaai#214)
745a2bb0 Removed non high voltage items. Added units.
fafd091a Added High Voltage Management to powertrain file.
15b6b316 Update subaru_global_2017.dbc
a12af19a Add steering error signal in subaru global
d411c175 correct max value
881c065d add electrical gear and fix driver torque
1bbac4b8 Add reference to CANdevStudio in README file
8f70ea01 Adds 2016 Honda CR-V Executive
5081966f One more fix
fa5dc680 Fix honda dbc files after steer torque addition
e4dfb2fa update honda steering signals (commaai#208)
53fc4487 added generator test (commaai#207)
cb27d6e3 Honda Nidec: add new ACC_HUD signals to all other cars other than the CIVIC
6e6779f9 build on mac AND linux, also gotta not use these python files
79dbfc1a build on mac
4f82d01e gitignore
5cb83454 Honda FCM: diagnostic signals
d309cdce Added linter to opendbc (commaai#203)
d452706f add requirements.txt
ec3b4595 deterministic dependency order
a265d351 Azure pipelines ci (commaai#202)
bce9a2e1 packer depends on libdbc
5d5fdd6a no more python version of libdbc, everything through cython
541705bf move CANDefine to parser code
da25c52a add test for can define
0ba7926b unify can packer and parser
25d88009 consistent naming
a5c640a5 fix linter
be210fef remove obsolete make file
ffd9dca7 opendbc needs cereal
b559f63d remove more make
d0929496 seems to work now
41e80836 don't make
3254d1fc think scons works
eb78f6aa scons sort of working
0ef1e35d fix gitignore
e155e017 Can migration (commaai#199)
3eded83a Honda: correct steering torque sensor sign to be consistent with standard convention (left+)
32f70e2f Fix outback endianness consistency (commaai#196)
a7da471f Update subaru_outback_2015_eyesight.dbc (commaai#195)

git-subtree-dir: opendbc
git-subtree-split: 5eeb33c5de14b331da901da0222de9c63ff93ab5
blue-genie pushed a commit to blue-genie/openpilot that referenced this pull request Nov 15, 2023
@sunnyhaibin
HKG: add Kia Seltos 2023-24 Non-SCC platform (commaai#215)
44b0b11 
* HKG: add Kia Seltos 2024 Non-SCC platform

* 2023 MY also works

* Update CHANGELOGS.md

* add fw

* fix

* fix list
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
@sunnyhaibin
Screenrecorder: fix layout hierarchy (commaai#215)
a4d793b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whitef0x0 @rbiasini