Split Mazda cars to : CX5, CX9, and Mazda3 #2097
Conversation
|
LGTM, will merge once we can get routes for each of the new models and tests pass. |
|
BTW @adeebshihadeh, I put all of the new models under a GEN1 set for Mazda generation 1 ADAS hardware. This make it easy to separate the logic for GEN2 hardware when we add support for it. |
|
Do the gen 2 models have the steering lockout or more torque? |
|
Hard to tell without having a car myself and without OP support, but users reported no lockout at least, but maybe more torque as well. |
Jafaral
force-pushed
the
mazda-models
branch
2 times, most recently
from
b42e4cb to
b025451
Compare
|
@adeebshihadeh the new routes are added, please see b025451 |
selfdrive/test/test_car_models.py
Outdated
| 'carFingerprint': MAZDA.CX9, | ||
| 'enableCamera': True, | ||
| }, | ||
| "74f1038827005090|2020-08-27--10-23-22": { |
There was a problem hiding this comment.
this route isn't uploaded
Jafaral
force-pushed
the
mazda-models
branch
2 times, most recently
from
5262801 to
0434da0
Compare
Jafaral
force-pushed
the
mazda-models
branch
from
0434da0 to
2ba64d2
Compare
|
@adeebshihadeh I updated the route for Mazda 6, can you please check if all of the routes are now passing ? |
selfdrive/test/test_car_models.py
Outdated
| 'carFingerprint': MAZDA.Mazda3, | ||
| 'enableCamera': True, | ||
| }, | ||
| "0f702597446474bf|2020-09-01--16-53-30": { |
There was a problem hiding this comment.
this route isn't uploaded
Jafaral
force-pushed
the
mazda-models
branch
from
2ba64d2 to
8532a91
Compare
selfdrive/car/mazda/interface.py
Outdated
| ret.lateralTuning.pid.kpV, ret.lateralTuning.pid.kiV = [[0.19], [0.019]] | ||
| ret.lateralTuning.pid.kf = 0.00006 | ||
|
|
||
| #Mazda6 params |
There was a problem hiding this comment.
remove these comments
Add test routes for CX9 and Mazda3 CX9: "10b5a4b380434151|2020-08-26--17-11-45" Mazda3: "74f1038827005090|2020-08-26--20-05-50" Signed-off-by: Jafar Al-Gharaibeh <to.jafar@gmail.com>
Jafaral
force-pushed
the
mazda-models
branch
from
8532a91 to
bf8828d
Compare
Jafaral
changed the title
|
Merging, test failure is unrelated to the PR |
All Mazda cars were registered as CX-5. This PR spilts them to different models
and fills in the relevant params and allows PID tuning per model.
Signed-off-by: Jafar Al-Gharaibeh to.jafar@gmail.com