Added 2020 Santa Fe fingerprint and updated interface values #1595
Conversation
Also changed the default color when OP is not engaged to Orange, like the stock system.
Updated from spec sheets from Hyundai for 2020 Santa Fe
|
Nothing = Off White = LDW Green = LKA Orange = Fault From my experience. |
|
Can you get and add the FW print? |
| @@ -25,7 +25,7 @@ class CAR: | |||
| KIA_STINGER = "KIA STINGER GT2 2018" | |||
| KONA = "HYUNDAI KONA 2019" | |||
| KONA_EV = "HYUNDAI KONA ELECTRIC 2019" | |||
| SANTA_FE = "HYUNDAI SANTA FE LIMITED 2019" | |||
| SANTA_FE = "HYUNDAI SANTA FE 2019-2020" | |||
There was a problem hiding this comment.
No need to change the year in the car name.
| @@ -96,7 +96,7 @@ def update(self, enabled, CS, frame, actuators, pcm_cancel_cmd, visual_alert, | |||
|
|
|||
|
|
|||
| # 20 Hz LFA MFA message | |||
| if frame % 5 == 0 and self.car_fingerprint in [CAR.SONATA, CAR.PALISADE]: | |||
| if frame % 5 == 0 and self.car_fingerprint in [CAR.SONATA, CAR.PALISADE, CAR.SANTA_FE]: | |||
There was a problem hiding this comment.
Would this be a problem for the 2019 Santa FE that doesn't have LFA? Otherwise we need to split them into two different cars. Maybe you can find someone on discord with a 2019 one and have them try this PR.
There was a problem hiding this comment.
2019 and 2020 are same platform
There was a problem hiding this comment.
Any vehicle that steers down to 0 has LFA supported.
There was a problem hiding this comment.
I test drove a 2019 Santa Fe and it has the same displays. I believe the only thing that is different between the 2019 and 2020 is the fingerprint.
| @@ -19,7 +19,7 @@ def create_lkas11(packer, frame, car_fingerprint, apply_steer, steer_req, | |||
| values["CF_Lkas_MsgCount"] = frame % 0x10 | |||
| values["CF_Lkas_Chksum"] = 0 | |||
|
|
|||
| if car_fingerprint in [CAR.SONATA, CAR.PALISADE]: | |||
| if car_fingerprint in [CAR.SONATA, CAR.PALISADE, CAR.SANTA_FE]: | |||
There was a problem hiding this comment.
Same comment as the lfa_mfa message.
CF_Lkas_FcwOpt_USM
|
I've changed the icon back to white. I didn't realize that it was causing faults. |
| @@ -74,6 +74,9 @@ class Buttons: | |||
| }, | |||
| { | |||
| 67: 8, 68: 8, 80: 4, 160: 8, 161: 8, 272: 8, 288: 4, 339: 8, 356: 8, 357: 8, 399: 8, 544: 8, 608: 8, 672: 8, 688: 5, 704: 1, 790: 8, 809: 8, 848: 8, 880: 8, 898: 8, 900: 8, 901: 8, 904: 8, 1056: 8, 1064: 8, 1065: 8, 1072: 8, 1075: 8, 1087: 8, 1088: 8, 1151: 8, 1200: 8, 1201: 8, 1232: 4, 1264: 8, 1265: 8, 1266: 8, 1296: 8, 1306: 8, 1312: 8, 1322: 8, 1331: 8, 1332: 8, 1333: 8, 1348: 8, 1349: 8, 1369: 8, 1370: 8, 1371: 8, 1407: 8, 1415: 8, 1419: 8, 1440: 8, 1442: 4, 1461: 8, 1470: 8 | |||
| }, | |||
| { | |||
| 67: 8, 127: 8, 304: 8, 320: 8, 339: 8, 356: 4, 544: 8, 593: 8, 608: 8, 688: 6, 809: 8, 832: 8, 854: 7, 870: 7, 871: 8, 872: 8, 897: 8, 902: 8, 903: 8, 905: 8, 909: 8, 916: 8, 1040: 8, 1042: 8, 1056: 8, 1057: 8, 1064: 8, 1078: 4, 1107: 5, 1136: 8, 1151: 6, 1155: 8, 1156: 8, 1168: 7, 1170: 8, 1173: 8, 1183: 8, 1186: 2, 1191: 2, 1227: 8, 1265: 4, 1280: 1, 1287: 4, 1290: 8, 1292: 8, 1294: 8, 1312: 8, 1322: 8, 1342: 6, 1345: 8, 1348: 8, 1363: 8, 1369: 8, 1379: 8, 1384: 8, 1407: 8, 1427: 6, 1456: 4, 1470: 8 | |||
There was a problem hiding this comment.
The fingerprint for the 2020 Santa Fe.
|
Can you share a cabana route with the stock system of your car? I'd like to check if's correct that we're now sending the |
|
Feel free to reopen after sharing a route. |
Added my 2020 Santa Fe's fingerprint as well as changed the values of the car in the interface.py.
I also changed the default color of the LKAS icon to orange. This is how the stock systems act when LKAS is not engaged. This just seems more normal to me.