Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru ACC speed units signals update #414

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

martinl
Copy link
Contributor

@martinl martinl commented Aug 20, 2021

This PR adds new Dashlights UNITS signal for Subaru Global models and changes Preglobal Dash_State2 UNITS signal. Both have been in use in subaru-community branch since beginning of July and they have been working reliably for all supported models.

@adeebshihadeh
Copy link
Contributor

No need to delete the old messages. Let's just add the new signals.

@martinl martinl force-pushed the subaru-acc-speed-units branch from 79085b1 to d535e78 Compare September 2, 2021 08:41
@martinl
Copy link
Contributor Author

martinl commented Sep 2, 2021

I kept the old messages and added new signals

@adeebshihadeh adeebshihadeh merged commit 78c639f into commaai:master Sep 2, 2021
@martinl martinl deleted the subaru-acc-speed-units branch September 3, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants