Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

car interfaces: each specify their own dependencies #2002

Merged
merged 11 commits into from
Mar 15, 2025

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 15, 2025

Removes need to define empty radar interface file, one less thing when porting a car. pytest collection time is not sped up with the static imports, so leaving that out until there's a cleaner solution

@sshane sshane changed the title start interfaces: no dynamic interface imports Mar 15, 2025
@github-actions github-actions bot added car related to opendbc/car/ toyota labels Mar 15, 2025
sshane added 2 commits March 14, 2025 22:18
This reverts commit 7b02e9c.
@sshane sshane changed the title interfaces: no dynamic interface imports interfaces: each specify their own dependencies Mar 15, 2025
@sshane sshane changed the title interfaces: each specify their own dependencies car interfaces: each specify their own dependencies Mar 15, 2025
@sshane sshane merged commit b46e634 into master Mar 15, 2025
8 checks passed
@sshane sshane deleted the no-dynamic-interface-imports branch March 15, 2025 05:36
lukasloetkolben pushed a commit to lukasloetkolben/opendbc that referenced this pull request Mar 19, 2025
* start

* do CS and CC

* RI

* fixes

* more

* remove these

* stash

* Revert "stash"

This reverts commit 7b02e9c.

* clean up

* nl
gadhadar pushed a commit to qzwf/opendbc that referenced this pull request Mar 21, 2025
* start

* do CS and CC

* RI

* fixes

* more

* remove these

* stash

* Revert "stash"

This reverts commit 7b02e9c.

* clean up

* nl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant