Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN FD safety: replace alt buttons live detection with param #1985

Merged
merged 5 commits into from
Mar 12, 2025

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 12, 2025

we need some pre-processor ASAP

for #1903, some cars have both messages so safety can select the wrong one randomly

@github-actions github-actions bot added the car safety vehicle-specific safety code label Mar 12, 2025
@sshane sshane changed the title alt buttons needs to be checked with the param Hyundai CAN FD safety: replace alt buttons live detection with param Mar 12, 2025
@sshane sshane merged commit cf41673 into master Mar 12, 2025
8 checks passed
@sshane sshane deleted the hyundai-canfd-alt-buttons-check branch March 12, 2025 06:15
chrispypatt pushed a commit to chrispypatt/opendbc that referenced this pull request Mar 12, 2025
…ommaai#1985)

* alt buttons needs to be checked with the param

* flip

* do tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant