Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyundai CAN FD: Fix steering messages in safety replay #1975

Merged
merged 3 commits into from
Mar 12, 2025

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Mar 11, 2025

Noticed a good amount of blocked tx messages when running some CAN FD routes via safety replay in this PR:

Before

replaying b5d6dc830ad63071|2022-12-12--21-28-25/12 with safety mode 28, param 13, alternative experience 0
no steering msgs found!

RX
total rx msgs: 190253
invalid rx msgs: 0
safety tick rx invalid: False
invalid addrs: set()

TX
total openpilot msgs: 10200
total msgs with controls allowed: 6698
blocked msgs: 265
blocked with controls allowed: 81
blocked addrs: Counter({298: 203, 416: 62})

After

replaying b5d6dc830ad63071|2022-12-12--21-28-25/12 with safety mode 28, param 13, alternative experience 0

RX
total rx msgs: 190253
invalid rx msgs: 0
safety tick rx invalid: False
invalid addrs: set()

TX
total openpilot msgs: 10200
total msgs with controls allowed: 6908
blocked msgs: 0
blocked with controls allowed: 0
blocked addrs: Counter()

@github-actions github-actions bot added the car safety vehicle-specific safety code label Mar 11, 2025
@sshane sshane merged commit bfad9b3 into commaai:master Mar 12, 2025
8 checks passed
@sshane sshane deleted the hyundai-canfd-safety-replay-fix branch March 12, 2025 07:01
chrispypatt pushed a commit to chrispypatt/opendbc that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car safety vehicle-specific safety code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants