Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit: match openpilot mypy config #69

Merged
merged 6 commits into from
Apr 27, 2022
Merged

pre-commit: match openpilot mypy config #69

merged 6 commits into from
Apr 27, 2022

Conversation

GregorKikelj
Copy link
Contributor

@adeebshihadeh
Copy link
Contributor

Make sure to enable the same flags here.

@GregorKikelj
Copy link
Contributor Author

Can you enable workflows btw? Want to ensure it all works :)

@GregorKikelj GregorKikelj marked this pull request as draft April 21, 2022 20:22
adeebshihadeh
adeebshihadeh reviewed Apr 21, 2022
View reviewed changes
requirements_examples.txt Outdated
@@ -9,4 +9,5 @@ matplotlib
cffi
gmplot
pycurl
types-pycurl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this goes in the pre-commit config. see the openpilot pre-commit config for an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GregorKikelj GregorKikelj marked this pull request as ready for review April 21, 2022 20:41
@GregorKikelj
Copy link
Contributor Author

Could add the --warn-unused-ignores to laika but I get a lot of missing stubs even after fixing numpy and pycurl

downloader.py:3: error: Cannot find implementation or library stub for module named "hatanaka"
raw_gnss.py:1: error: Skipping analyzing "scipy.optimize": module is installed, but missing library stubs or py.typed marker
raw_gnss.py:1: error: Skipping analyzing "scipy": module is installed, but missing library stubs or py.typed marker
dgps.py:4: error: Skipping analyzing "scipy.spatial": module is installed, but missing library stubs or py.typed marker
dgps.py:4: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports

@adeebshihadeh adeebshihadeh changed the title mypy PR pre-commit: match openpilot mypy config Apr 27, 2022
@adeebshihadeh adeebshihadeh merged commit 226adc6 into commaai:master Apr 27, 2022
@GregorKikelj GregorKikelj deleted the types branch April 27, 2022 21:05
budney pushed a commit to budney/laika that referenced this pull request Jun 8, 2022
@GregorKikelj @adeebshihadeh
pre-commit: match openpilot mypy config (commaai#69)
9fff297 
* types

* CI

* ci v2

* ci v3

* ci v4

* add openpilot flags

Co-authored-by: Adeeb Shihadeh <adeebshihadeh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeebshihadeh adeebshihadeh adeebshihadeh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GregorKikelj @adeebshihadeh @grekiki2