Use GitHub Actions native container support for manylinux builds#48
Draft
greatgitsby wants to merge 1 commit intocommaai:masterfrom
Draft
Use GitHub Actions native container support for manylinux builds#48greatgitsby wants to merge 1 commit intocommaai:masterfrom
greatgitsby wants to merge 1 commit intocommaai:masterfrom
Conversation
Instead of spawning Docker containers via `docker run` inside build.sh, use the `container:` directive so Linux jobs run directly inside the manylinux images. This is cleaner and avoids Docker-in-Docker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
container:directive in CI so Linux build jobs run directly insidemanylinux_2_28images instead of spawning Docker containers viadocker runMANYLINUXenv var withBUILD_SH_IN_MANYLINUXand setUV_PYTHONto the manylinux Python 3.12build.sh— existingBUILD_SH_IN_MANYLINUXlogic already handles thisTest plan
🤖 Generated with Claude Code