raylib: auto-detect aarch64 as PLATFORM_COMMA#47
Closed
adeebshihadeh wants to merge 2 commits intomasterfrom
Closed
raylib: auto-detect aarch64 as PLATFORM_COMMA#47adeebshihadeh wants to merge 2 commits intomasterfrom
adeebshihadeh wants to merge 2 commits intomasterfrom
Conversation
The /TICI file doesn't exist during CI builds on ubuntu-24.04-arm, so the platform detection fell through to PLATFORM_DESKTOP which links against X11. This caused "GLFW: X11: The DISPLAY environment variable is missing" errors on comma devices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 60e184d.
Contributor
Author
|
Not needed — the fix belongs in agnos-builder's Dockerfile instead (set RAYLIB_PLATFORM=PLATFORM_COMMA at build time). Auto-detecting aarch64 as PLATFORM_COMMA would break non-comma aarch64 devices. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PLATFORM_COMMAin bothbuild.shandbuild.py/TICIfile, which doesn't exist during CI builds onubuntu-24.04-armPLATFORM_DESKTOPwhich links against X11/libGLX, causingGLFW: X11: The DISPLAY environment variable is missingon comma devicesTest plan
lddthat the built_raylib_cffi.abi3.sohas no X11 dependencies🤖 Generated with Claude Code